|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2004-08-02 17:38 UTC] msm at manley dot org
Description: ------------ Is there an issue with extract() using EXTR_REFS when more than one symbol points to an array variable? EXTR_REF "extracts variables as references. This effectively means that the values of the imported variables are still referencing the values of the var_array parameter." (from http://us2.php.net/manual/en/function.extract.php) From some experiments, I think that this function has issues when you pass it an array that has been given a reference or pass in a reference to an array itself. It three of the four testcases shown below, it would appear that the extracted variable $foo is NOT actually a reference into $array['foo'] after the extract() call. PHP does lazy copies on arrays. Does modifying an array via a reference to one of the array's members not trigger the lazy copy? This is not the bug (and makes sense to me), though it certainly added to the confusion trying to figure out what was happenning here. The testcases return the same results under PHP 4.3.4, PHP 4.3.8 and PHP 5.0.0 on all the FreeBSD, Linux and Windows systems I have access to. Reproduce code: --------------- I describe four testcases and their output at http://www.sitepoint.com/forums/showthread.php?p=1329965 Sorry, the testcases are longer than 20 lines, all total. In summary: 1) Copy array by reference -- $array_b =& $array_a -- and then extract(array, EXTR_REFS) from each. 2) Copy array by value -- $array_b = $array_a -- and then extract(array, EXTR_REFS) from each. 3) Copy array by reference, then modify a value in the array, then extract(array, EXTR_REFS) from each. 4) Copy array by value, then modify a value in the array (triggering the lazy copy), then extract(array, EXTR_REFS) from each. Expected result: ---------------- In each testcase, given an array ('foo' => 'value') I expect to see a variable $foo that is a reference to $array['foo'] and when I change $foo's value, the value of $array['foo'] should change accordingly. Actual result: -------------- Is the first three testcases $foo appears not to be a reference to $array_a['foo'] or $array_b['foo']. In the fourth testcase, extract(array, EXTR_REFS) performs as expected. PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Thu Nov 21 12:01:29 2024 UTC |
I shortened my testcases down to the following: <?php rc1(); rc2(); rc3(); function rc1() { echo "\n\n1: array copy by value\n"; $a = array( 'foo' => 'bar'); $b = $a; $b['foo'] = 'diff'; print_r($a); echo "\n-----\nnow extract from a with EXTR_REFS\n"; extract($a,EXTR_REFS); echo "post extract, foo = $foo\n"; $foo = 'noo'; echo "post reassign, foo = $foo\n"; print_r($a); print_r($b); } function rc2() { echo "\n\n2: array copy by reference\n"; $a = array( 'foo' => 'bar'); $b =& $a; print_r($a); echo "\n-----\nnow extract from a with EXTR_REFS\n"; extract($a,EXTR_REFS); echo "post extract, foo = $foo\n"; $foo = 'noo'; echo "post reassign, foo = $foo\n"; print_r($a); } function rc3() { echo "\n\n3: array copy by reference then unset copy\n"; $a = array( 'foo' => 'bar'); $b =& $a; unset($b); print_r($a); echo "\n-----\nnow extract from a with EXTR_REFS\n"; extract($a,EXTR_REFS); echo "post extract, foo = $foo\n"; $foo = 'noo'; echo "post reassign, foo = $foo\n"; print_r($a); } ?> Testcases 1 and 3 pass - $foo is a ref to $a['foo']. Testcase 2 fails -- $foo does not appear to be a ref to $a['foo'].The problem lies in extract()'s use of the SEPARATE_ZVAL macro in ext/standard/array.c. That macro actually makes a full copy of a ZVAL if the ZVAL's refcount is > 1. I assume that's used when doing lazy copies, normally. The existing extract() function uses SEPARATE_ZVAL_TO_MAKE_IS_REF to set is_ref = 1 in the ZVAL. When the refcount on the extract()ed array is 1, no copy is made and the extracted variables are refs to the array member. When the refcount is > 1, a copy of the array entry gets made by SEPARATE_ZVAL and the extracted variable end up as refs to the copy. Here is a patch that I believe fixes the problem. So far a modified version of PHP 5.0.0 has passed all the testcases with this patch in place. --- array.c Wed Aug 4 15:54:40 2004 +++ array.c.msm Wed Aug 4 16:42:01 2004 @@ -1372,7 +1372,7 @@ if (extract_refs) { zval **orig_var; - SEPARATE_ZVAL_TO_MAKE_IS_REF(entry); + (*(entry))->is_ref = 1; zval_add_ref(entry); if (zend_hash_find(EG(active_symbol_table), final_name.c, final_name.len+1, (void **) &orig_var) == SUCCESS) {