Patch xmlrpc_set_type-return-value for XMLRPC-EPI related Bug #70526

Patch version 2015-09-18 20:10 UTC

• 2015-09-18 20:10 UTC [diff to current]

Developer: rainer.jung@kippdata.de

--- ext/xmlrpc/xmlrpc-epi-php.c	2015-09-03 23:32:56.000000000 +0200
+++ ext/xmlrpc/xmlrpc-epi-php.c	2015-09-18 22:04:39.765901000 +0200
@@ -1283,7 +1283,7 @@
 
 						convert_to_object(value);
 						if (zend_hash_str_update(Z_OBJPROP_P(value), OBJECT_TYPE_ATTR, sizeof(OBJECT_TYPE_ATTR) - 1, &type)) {
-							bSuccess = zend_hash_str_update(Z_OBJPROP_P(value), OBJECT_VALUE_TS_ATTR, sizeof(OBJECT_VALUE_TS_ATTR) - 1, &ztimestamp) != NULL;
+							bSuccess = zend_hash_str_update(Z_OBJPROP_P(value), OBJECT_VALUE_TS_ATTR, sizeof(OBJECT_VALUE_TS_ATTR) - 1, &ztimestamp) != NULL ? SUCCESS : FAILURE;
 						}
 					} else {
 						zval_ptr_dtor(&type);
@@ -1294,7 +1294,7 @@
 				}
 			} else {
 				convert_to_object(value);
-				bSuccess = zend_hash_str_update(Z_OBJPROP_P(value), OBJECT_TYPE_ATTR, sizeof(OBJECT_TYPE_ATTR) - 1, &type) != NULL;
+				bSuccess = zend_hash_str_update(Z_OBJPROP_P(value), OBJECT_TYPE_ATTR, sizeof(OBJECT_TYPE_ATTR) - 1, &type) != NULL ? SUCCESS : FAILURE;
 			}
 		}
 	}