Patch svn.c.diff for svn Bug #68441

Patch version 2014-11-18 03:23 UTC

• 2014-11-18 03:23 UTC [diff to current]

Developer: ashish.is@lostca.se

Citing from PHP documentation[1]:


! 	the preceeding parameter can be of the specified type or null For 'b', 'l' and 'd', 
        an extra argument of type zend_bool* must be passed after the corresponding bool*, 
        long* or double* addresses which will be set true if null is recieved.

As per documentation of svn_diff(3), the revision arguments needs to be a number, thus
not actually needing '!' specifier, which makes sense for the parameters getting passed.

[1] http://in.php.net/manual/en/internals2.funcs.php

--- svn-1.0.2/svn.c.orig	2014-11-18 02:45:40.583187999 +0000
+++ svn-1.0.2/svn.c	2014-11-18 02:47:02.971502284 +0000
@@ -1224,7 +1224,7 @@
 	svn_opt_revision_t revision1, revision2;
 	zend_bool ignore_content_type = 0;
 
-	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sl!sl!",
+	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "slsl",
 			&path1, &path1len, &rev1,
 			&path2, &path2len, &rev2)) {
 		return;