Patch bug_64308.patch for oauth Bug #64308
Patch version 2013-11-12 22:22 UTC
Return to Bug #64308 |
Download this patch
Patch Revisions:
Developer: mjpelmear@gmail.com
diff -rupN oauth-1.2.3/oauth.c oauth-1.2.3-bug_64308/oauth.c
--- oauth-1.2.3/oauth.c 1970-01-01 01:13:08.000000000 -0800
+++ oauth-1.2.3-bug_64308/oauth.c 2013-11-12 14:02:45.038375782 -0800
@@ -696,6 +696,8 @@ char *oauth_generate_sig_base(php_so_obj
smart_str sbuf = {0};
urlparts = php_url_parse_ex(uri, strlen(uri));
+ php_strtolower(urlparts->scheme, strlen(urlparts->scheme));
+ php_strtolower(urlparts->host, strlen(urlparts->host));
if (urlparts) {
if (!urlparts->host || !urlparts->scheme) {
diff -rupN oauth-1.2.3/tests/bug_64308.phpt oauth-1.2.3-bug_64308/tests/bug_64308.phpt
--- oauth-1.2.3/tests/bug_64308.phpt 1969-12-31 16:00:00.000000000 -0800
+++ oauth-1.2.3-bug_64308/tests/bug_64308.phpt 2013-11-12 13:57:18.578387396 -0800
@@ -0,0 +1,12 @@
+--TEST--
+PECL oauth: Bug #64308 (Protocol and host name not lowercased when generating signature base string)
+--SKIPIF--
+<?php # vim:ft=php
+if (!extension_loaded('oauth')) die('skip');
+?>
+--FILE--
+<?php
+echo oauth_get_sbs('GET', 'HTTP://SimonWpt.trovebox.com/hello.json').PHP_EOL;
+?>
+--EXPECT--
+GET&http%3A%2F%2Fsimonwpt.trovebox.com%2Fhello.json&
|