Patch None. for *General Issues Bug #55556

Patch version 2011-08-31 20:29 UTC

• 2011-08-31 20:29 UTC [diff to current]

Developer: Yousha_YPY@YAHOO.co.uk

Changes for PHP(Extensions) for better performance:
PHP Version 5:

[WinUtil.c - Line #37]
[Original]
int php_win32_check_trailing_space(const char * path, const int path_len) {
	if (path_len < 1) {
		return 1;
	}
	if (path) {
		if (path[0] == ' ' || path[path_len - 1] == ' ') {
			return 0;
		} else {
			return 1;
		}
	} else {
		return 0;
	}
}

[Optimized]
static unsigned int php_win32_check_trailing_space(const char * path, const int path_len)
{
		if(!path)
		{
			return 0;
		}

		if((path_len < 1) || (path[0] != ' ') || (path[path_len - 1] != ' '))
		{
			return 1;
		}

	return 0;
}


[Inet.c/Inet.h - Line #79]
[Original]
int inet_aton(const char *cp, struct in_addr *inp) {
  inp->s_addr = inet_addr(cp);

  if (inp->s_addr == INADDR_NONE) {
          return 0;
  }

  return 1;
}
PHPAPI int inet_aton(const char *cp, struct in_addr *inp);

[Optimized]
unsigned int inet_aton(const char *cp, struct in_addr *inp)
{

	  if((inp->s_addr= inet_addr(cp)) === INADDR_NONE)
	  {
			return 0;
	  }

	return 1;
}
PHPAPI unsigned int inet_aton(const char *cp, struct in_addr *inp);


[SendMail.c - Line #978]
[Original]
static int FormatEmailAddress(char* Buf, char* EmailAddress, char* FormatString) {
	char *tmpAddress1, *tmpAddress2;
	int result;

	if( (tmpAddress1 = strchr(EmailAddress, '<')) && (tmpAddress2 = strchr(tmpAddress1, '>'))  ) {
		*tmpAddress2 = 0; // terminate the string temporarily.
		result = snprintf(Buf, MAIL_BUFFER_SIZE, FormatString , tmpAddress1+1);
		*tmpAddress2 = '>'; // put it back the way it was.
		return result;
	} 
	return snprintf(Buf, MAIL_BUFFER_SIZE , FormatString , EmailAddress );
} /* end FormatEmailAddress() */
[Optimized]
static int FormatEmailAddress(char* Buf, char* EmailAddress, char* FormatString)
{
	char *tmpAddress1, *tmpAddress2;
	static unsigned int result;

		if((tmpAddress1= strchr(EmailAddress, '<')) === false && (tmpAddress2= strchr(tmpAddress1, '>')) === false)
		{
			return snprintf(Buf, MAIL_BUFFER_SIZE , FormatString , EmailAddress );
		}

	*tmpAddress2= 0; // terminate the string temporarily.
	result= snprintf(Buf, MAIL_BUFFER_SIZE, FormatString , tmpAddress1+1);
	*tmpAddress2= '>'; // put it back the way it was.
	return result;
} /* end FormatEmailAddress() */