Patch bugsweb-security.diff for Website problem Bug #60989

Patch version 2012-05-05 20:25 UTC

Obsoleted by patches:

• bugsweb-security.diff, revision 2012-05-05 20:28 UTC
• bugsweb-security.diff, revision 2012-05-06 19:03 UTC
• bugsweb-security.diff, revision 2012-05-07 20:59 UTC

• 2012-05-07 20:59 UTC [diff to current]
• 2012-05-06 19:03 UTC [diff to current]
• 2012-05-05 20:28 UTC [diff to current]
• 2012-05-05 20:25 UTC [diff to current]

Developer: tyrael@php.net

diff --git a/include/functions.php b/include/functions.php
index 6a6f5c4..30f0af7 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -117,10 +117,6 @@ function bugs_has_access ($bug_id, $bug, $pw, $user_flags)
 	} else if (($user_flags == BUGS_NORMAL_USER) && $pw != '' && verify_bug_passwd($bug_id, $pw)) {
 		// The submitter
 		return true;
-	} else if (($user_flags == BUGS_DEV_USER) && $bug['reporter_name'] != '' &&
-		strtolower($bug['reporter_name']) == strtolower($auth_user->handle)) {
-		// The submitter (php developer)
-		return true;
 	} else if (($user_flags & BUGS_DEV_USER) && $bug['assign'] != '' &&
 		strtolower($bug['assign']) == strtolower($auth_user->handle)) {
 		// The assigned dev
diff --git a/www/bug.php b/www/bug.php
index 03cb7c4..5d37606 100644
--- a/www/bug.php
+++ b/www/bug.php
@@ -605,9 +605,6 @@ switch ($thanks)
 
 display_bug_error($errors);
 
-if (!$show_bug_info) {
-	echo '<div id="bugheader"></div>';
-} else{
 ?>
 <div id="bugheader">
 	<table id="details">
@@ -671,9 +668,7 @@ if (!$show_bug_info) {
 	</table>
 </div>
 
-<?php
-}
-if ($bug_id !== 'PREVIEW') {
+<?php if ($bug_id !== 'PREVIEW') {
 	echo '<div class="controls">', "\n",
 		control(0, 'View'),
 		($bug['private'] == 'N' ? control(3, 'Add Comment') : ''),
@@ -755,10 +750,7 @@ if ($edit == 1 || $edit == 2) { ?>
 <form id="update" action="bug.php?id=<?php echo $bug_id; ?>&amp;edit=<?php echo $edit; ?>" method="post">
 
 <?php if ($edit == 2) {
-		if ($logged_in && $show_bug_info) {
-			// do nothing if the user is logged in and has access to the bug
-
-		} elseif (!isset($_POST['in']) && $pw && verify_bug_passwd($bug['id'], bugs_get_hash($pw))) {
+		if (!isset($_POST['in']) && $pw && verify_bug_passwd($bug['id'], bugs_get_hash($pw))) {
 			$show_bug_info = true;	?>
 			<div class="explain">
 				Welcome back! Since you opted to store your bug's password in a
@@ -819,7 +811,7 @@ if ($edit == 1 || $edit == 2) { ?>
 ?>
 	<table>
 
-<?php if ($edit == 1 && $show_bug_info) { /* Developer Edit Form */ ?>
+<?php if ($edit == 1) { /* Developer Edit Form */ ?>
 		<tr>
 			<th class="details"><label for="in" accesskey="c">Qui<span class="accesskey">c</span>k Fix:</label></th>
 			<td colspan="3">
@@ -1021,7 +1013,7 @@ if (!$logged_in) {
 // Display original report
 if ($bug['ldesc']) {
 	if (!$show_bug_info) {
-		//echo '<input type="checkbox" name="in[private]" value="Y" '.($is_private == 'Y' ? 'checked="checked"' : '').' /> ';
+		echo '<input type="checkbox" name="in[private]" value="Y" '.($is_private == 'Y' ? 'checked="checked"' : '').' /> ';
 		echo 'This bug report is marked as private.';
 	} else if ($bug['status'] !== 'Spam') {
 		output_note(0, $bug['submitted'], $bug['email'], $bug['ldesc'], 'comment', $bug['reporter_name'], false);