php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #81343 pdo_pgsql: Inconsitent boolean conversion after calling closeCursor()
Submitted: 2021-08-10 12:09 UTC Modified: -
From: phofstetter at sensational dot ch Assigned:
Status: Closed Package: PDO PgSQL
PHP Version: 8.1.0beta2 OS: macOS
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: phofstetter at sensational dot ch
New email:
PHP Version: OS:

 

 [2021-08-10 12:09 UTC] phofstetter at sensational dot ch
Description:
------------
After calling closeCursor() on a Postgres PDO statement handle, the conversion behavior for boolean values will change:

prior to calling closeCursor, boolean values in the database get converted to PHP boolean values.

after calling closeCursor() (and subsequently calling execute() again), boolean values will be converted to strings 't' and 'f'

This was fine in PHP 8.0, broken in PHP 8.1b2 at least, though I'll update this bug with after some bisecting to find the specific commit.

Test script:
---------------
$pdo = new PDO('pgsql:host=localhost;port=5432;user=someuser;dbname=somedb');
$sth = $pdo->prepare("select false where 2=?");

for ($i = 0; $i < 2; $i++) {
    $sth->execute([2]);
    var_dump($sth->fetchColumn(0));
    $sth->closeCursor();
}

Expected result:
----------------
bool(false)
bool(false)

Actual result:
--------------
bool(false)
string(1) "f"

Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-08-10 13:03 UTC] phofstetter at sensational dot ch
According to git bisect, commit caa710037e663fd78f67533b29611183090068b2 is where this broke.

> Rewrite PDO result binding

commit subject checks out :p
 [2021-08-10 13:32 UTC] phofstetter at sensational dot ch
The following pull request has been associated:

Patch Name: fix bug 81343: inconsistent type conversion after closeCursor
On GitHub:  https://github.com/php/php-src/pull/7355
Patch:      https://github.com/php/php-src/pull/7355.patch
 [2021-08-10 13:34 UTC] phofstetter at sensational dot ch
I have attached a PR that fixes the problem, though I would love to get a review by Nikita who did the big PDO result refactoring. 

I'm not entirely sure it's safe to not free S->cols, but reading the code, I believe cols is freed in the statement destructor anyways.

The other approach would be to restore the freeing of the column metadata and call `describe` again on subsequent execs
 [2021-08-11 16:24 UTC] git@php.net
Automatic comment on behalf of pilif (author) and nikic (committer)
Revision: https://github.com/php/php-src/commit/ace8fba759f54c9be128321dd2153778fb3d457e
Log: Fix bug #81343: inconsistent type conversion after closeCursor
 [2021-08-11 16:24 UTC] git@php.net
-Status: Open +Status: Closed
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Fri Dec 03 13:03:38 2021 UTC