php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #81029 SOAP HTTP socket not closing on object destruction
Submitted: 2021-05-11 10:32 UTC Modified: 2021-05-17 14:43 UTC
Votes:5
Avg. Score:5.0 ± 0.0
Reproduced:5 of 5 (100.0%)
Same Version:1 (20.0%)
Same OS:2 (40.0%)
From: kdonaldson at staff dot nexigen dot digital Assigned:
Status: Open Package: SOAP related
PHP Version: 7.4.19 OS: macOS and Cent OS 7
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: kdonaldson at staff dot nexigen dot digital
New email:
PHP Version: OS:

 

 [2021-05-11 10:32 UTC] kdonaldson at staff dot nexigen dot digital
Description:
------------
If a SoapClient object is constructed without specifying the 'keep_alive' option to false, the socket never appears to be closed if it falls out of scope

The provided script should be able to reproduce this, you can check the open sockets by running the script like: "php /path/to/script.php &" and using the resulting PID on "lsof -a -p {pid}"

You should slowly see a list of TCP connections slowly build up over time similar to this:

php     4396 vagrant    3u  IPv4  53416      0t0     TCP homestead:57814->ec2-52-7-155-169.compute-1.amazonaws.com:https (ESTABLISHED)
php     4396 vagrant    4u  IPv4  53447      0t0     TCP homestead:57816->ec2-52-7-155-169.compute-1.amazonaws.com:https (ESTABLISHED)
php     4396 vagrant    5u  IPv4  54451      0t0     TCP homestead:57818->ec2-52-7-155-169.compute-1.amazonaws.com:https (ESTABLISHED)

If instead you were to add ['keep_alive' => false] as the options parameter on the SoapClient you'll see that the TCP connections don't appear to build up.

While I do understand the purpose of Keep Alive to keep a single connection open, I would assume this is still a bug as the SoapClient has gone out of scope and new SoapClient objects don't appear to reuse the existing connection and simply ignore it creating a new one.

Test script:
---------------
<?php

function call(int $number) {
    $client = new SoapClient('https://www.dataaccess.com/webservicesserver/NumberConversion.wso?WSDL');
    $response = $client->NumberToWords(['ubiNum' => $number]);
    return $response->NumberToWordsResult;
}

$numbers = array_fill(0, 10000, 1);

foreach ($numbers as $number) {
    call($number);
}

Expected result:
----------------
The socket to be closed when the SoapClient object falls out of scope or destructs

Actual result:
--------------
The socket stays open and contributes to the open file limit / file descriptor limit

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-05-11 11:27 UTC] cmb@php.net
It seems to me we're missing to undo the refcount increment[1]
when the object is destroyed.

[1] <https://github.com/php/php-src/blob/php-7.4.19/ext/soap/php_http.c#L523>
 [2021-05-17 14:43 UTC] nikic@php.net
@cmb: As it's stored in a property, shouldn't that happen automatically when the object (and thus also its properties) are destroyed?
 [2022-12-08 06:00 UTC] kimia dot salamsao9881 at gmail dot com
That was unexpected. 
(https://www.mynordstrom.ltd/)github.com
 [2022-12-15 11:06 UTC] johnsonsellen at gmail dot com
That was unpredicted. 
(https://dolgeneraldgme.com/)github.com
 [2022-12-21 08:54 UTC] jbriss at ebridge dot sk
The problem seems to be discussed here too:

https://github.com/googleads/googleads-php-lib/commit/17bf38ce7ba0a994f317ea78df40539f89a89789
 [2022-12-21 11:45 UTC] schamberumarcelo at gmail dot com
This closes the socket, but the web services engine does not recognize this as being closed and tries to reuse it, resulting in exceptions. The requests module leaves a connection open until it is garbage. when the response object is dropped, the file would be closed.  
(https://www.myccpay.me)github.com
 [2023-01-14 14:00 UTC] insidestrongs at gmail dot com
That was unimageable 
(https://www.mynstromy.com/)github.com
 
PHP Copyright © 2001-2023 The PHP Group
All rights reserved.
Last updated: Sat Jan 28 14:05:52 2023 UTC