php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #80850 Missing LuaSandbox DLLs on PECL
Submitted: 2021-03-10 10:53 UTC Modified: 2021-05-19 09:24 UTC
From: cmb@php.net Assigned: tstarling (profile)
Status: Closed Package: PECL (PECL)
PHP Version: 7.4.16 OS: Windows
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: cmb@php.net
New email:
PHP Version: OS:

 

 [2021-03-10 10:53 UTC] cmb@php.net
Description:
------------
Obviously, there are no LuaSandbox DLLs available for download
on PECL.  The primary reason is that config.w32 is missing in the
packages, although it exists in the repo[1].  If the missing config.w32
is just an oversight, please add it.

If it gets added, the next issue would be the check for
lua5.1.lib, which appears to be overly restricted.  There are lua
packages available for PECL builds[2], but these have lua 5.3.4,
and the library is named liblua.lib.  It would be good to add at
least a fallback for that name, i.e. something like

    CHECK_LIB("lua5.1.lib;liblua.lib", "luasandbox", PHP_LUASANDBOX)

[1] <https://phabricator.wikimedia.org/diffusion/MLUS/browse/master/config.w32>
[2] <https://windows.php.net/downloads/pecl/deps/>


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-03-10 10:55 UTC] cmb@php.net
-Assigned To: +Assigned To: tstarling
 [2021-03-10 16:34 UTC] legoktm at member dot fsf dot org
The config.w32 omission is accidental, I'll get that fixed for the next release.

However, LuaSandbox is specific to Lua 5.1, so 5.3 won't work. <https://phabricator.wikimedia.org/T178146> goes into more detail about this.

Is it possible to add Lua 5.1 to the list of Windows dependencies?
 [2021-03-10 18:00 UTC] cmb@php.net
> The config.w32 omission is accidental, I'll get that fixed for
> the next release.

Thanks!

> Is it possible to add Lua 5.1 to the list of Windows
> dependencies?

Yes, I'll do that ASAP.
 [2021-05-19 07:20 UTC] legoktm at member dot fsf dot org
Per <https://windows.php.net/downloads/pecl/releases/luasandbox/4.0.2/> this is fixed now!

I don't believe I have permissions to close this bug though if someone could do that.
 [2021-05-19 09:24 UTC] cmb@php.net
-Status: Assigned +Status: Closed
 [2021-05-19 09:24 UTC] cmb@php.net
Ah, right!
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Tue Jun 15 18:01:24 2021 UTC