php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #79698 timelib mishandles future timestamps (triggered by 'zic -b slim')
Submitted: 2020-06-13 20:00 UTC Modified: 2020-06-13 20:03 UTC
From: eggert at cs dot ucla dot edu Assigned:
Status: Open Package: Date/time related
PHP Version: 7.4.7 OS: any
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please — but make sure to vote on the bug!
Your email address:
MUST BE VALID
Solve the problem:
38 - 35 = ?
Subscribe to this entry?

 
 [2020-06-13 20:00 UTC] eggert at cs dot ucla dot edu
Description:
------------
Since tzdb 2019b, the 'zic' command has had a '-b slim' option that generates smaller-but-equivalent TZif files, intended to save memory/cache/whatever. These files conform to the TZif format specified in Internet RFC 8536 and are supported by tzcode, glibc, etc. and '-b slim' is intended to be the default in future tzdb releases. However, some current PHP timelib test cases fail with slim TZif files.

This mishandling seems to occur because timelib gets confused about timestamps after the last explicit transition in a TZif file. For example, 'zic -b slim' generates a TZif file Europe/Amsterdam where the last explicit transition is on 1996-03-31 and transitions thereafter are deduced from the "CET-1CEST,M3.5.0,M10.5.0/3" string embedded at the end of the TZif file. The test case decoding 2008-03-30 01:00:00 fails, I expect because this timestamp is after the last explicit transition.

If my guess is right, timelib also mishandles timestamps past the last explicit transition even in traditional "fat" TZif files. For example, since the last transition in a traditional Europe/Amsterdam file is 2037-10-25 I would expect timelib to mishandle some timestamps after that.

As the '-b slim' option becomes more popular this problem will affect PHP even for past and current timestamps, so the bug needs to be fixed sooner than 2038.

Test script:
---------------
#!/bin/sh
# This assumes a typical GNU/Linux host.

wget https://data.iana.org/time-zones/releases/tzdb-2020a.tar.lz
tar xf tzdb-2020a.tar.lz
cd tzdb-2020a
make
make ZFLAGS='-b slim' posix_only  # This needs root privileges!
cd ..

git clone https://github.com/derickr/timelib.git
cd timelib
make test

Expected result:
----------------
I expect all tests in 'make test' to succeed.

Actual result:
--------------
Most tests succeed, but I see the following failures:

transition.render
FAIL | 2008-03-30 02:00:00 CEST Europe/Amsterdam | 1206835200 (Europe/Amsterdam) 
EXP  = 2008-03-30 01:00:00 CET Europe/Amsterdam
FAIL | 2008-03-30 02:59:59 CEST Europe/Amsterdam | 1206838799 (Europe/Amsterdam) 
EXP  = 2008-03-30 01:59:59 CET Europe/Amsterdam
...

render.render
...
FAIL | 2005-10-30 03:00:00 CEST Europe/Oslo | 1130634000 (Europe/Oslo) 
EXP  = 2005-10-30 02:00:00 CET Europe/Oslo
...
FAIL | 2005-10-30 03:00:00 CEST Europe/Amsterdam | 1130634000 (Europe/Amsterdam) 
EXP  = 2005-10-30 02:00:00 CET Europe/Amsterdam
FAIL | 2005-10-30 04:00:00 CEST Europe/Amsterdam | 1130637600 (Europe/Amsterdam) 
EXP  = 2005-10-30 03:00:00 CET Europe/Amsterdam
FAIL | 2005-10-30 05:00:00 CEST Europe/Amsterdam | 1130641200 (Europe/Amsterdam) 
EXP  = 2005-10-30 04:00:00 CET Europe/Amsterdam


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-06-13 20:03 UTC] nikic@php.net
Can you please report this issue upstream at https://github.com/derickr/timelib/issues?
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Wed Dec 02 00:01:23 2020 UTC