php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #79639 run-tests doesn't pass all info down to workers
Submitted: 2020-05-27 03:31 UTC Modified: 2020-06-19 08:20 UTC
From: dragoonis@php.net Assigned: nikic (profile)
Status: Closed Package: Testing related
PHP Version: master-Git-2020-05-27 (Git) OS: All
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: dragoonis@php.net
New email:
PHP Version: OS:

 

 [2020-05-27 03:31 UTC] dragoonis@php.net
Description:
------------
As per chats on Room 11. run-tests with parallel enabled, it doesn't pass down all info to the workers. 

One example (of many?) is a fatal error when using --html option with parallel. The fopen handle() doesn't get passed down to the worker, as the "resource" in $GLOBAL memory doesn't get sent over.


The bug fix is available on github, I'll reference the bug number there.

Test script:
---------------
make TEST_PHP_ARGS="--html report.html -j2" test

Expected result:
----------------
Tests run

Actual result:
--------------
Fatal error: Uncaught TypeError: fwrite(): Argument #1 ($handle) must be of type resource, int given in /home/dragoonis/code/php-src/run-tests.php:3332


Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-05-27 06:49 UTC] cmb@php.net
The following pull request has been associated:

Patch Name: Fix #79639 - Preserving the html report options in parallel worker mode
On GitHub:  https://github.com/php/php-src/pull/5632
Patch:      https://github.com/php/php-src/pull/5632.patch
 [2020-05-27 06:49 UTC] cmb@php.net
-Status: Open +Status: Verified
 [2020-06-19 08:20 UTC] nikic@php.net
-Status: Verified +Status: Closed -Assigned To: +Assigned To: nikic
 [2020-06-19 08:20 UTC] nikic@php.net
Closing this as the --html mode has been removed, which also fixes this issue :)
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Sat Jul 04 20:01:04 2020 UTC