php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #78961 erroneous optimization of re-assigned $GLOBALS
Submitted: 2019-12-14 04:13 UTC Modified: 2019-12-16 09:04 UTC
From: szargv at qq dot com Assigned: dmitry (profile)
Status: Closed Package: opcache
PHP Version: 7.4.0 OS: CentOS 7 64Bit
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: szargv at qq dot com
New email:
PHP Version: OS:

 

 [2019-12-14 04:13 UTC] szargv at qq dot com 
Description:
------------
PHP 7.4 + CentOS 7
in CLI mode
when opcache.enable_cli=1 it shows null
when opcache.enable_cli=0 it shows 3

my email is szargv@qq.com

Test script:
---------------
<?php
switch (1){
    case 1:
        
        $GLOBALS = array();
        $GLOBALS['td'] = array();
        $GLOBALS['td']['nsno'] = 3;
        var_dump($GLOBALS['td']['nsno']);
    break;
}

Expected result:
----------------
in CLI mode
when opcache.enable_cli=1 it shows null
when opcache.enable_cli=0 it shows 3

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-12-14 04:23 UTC] bugreports at gmail dot com 
confirmed

alias php-opcache='/usr/bin/php -d "zend_extension=opcache.so" -d "opcache.enable_cli=1"'

php test.php
int(3)

php-opcache test.php
Notice: Undefined index: nsno in test.php on line 7
NULL
 [2019-12-14 04:28 UTC] bugreports at gmail dot com 
FWIW: Happens only with the '$GLOBALS = array();'
 [2019-12-14 04:32 UTC] bugreports at gmail dot com 
there must be something corrupt because you can't even detect that in code - !isset($GLOBALS['bug_78961']['nsno']) don't fire the line before - was attempted to write some regression test for it

<?php declare(strict_types=1);
switch (1){
    case 1:
        $GLOBALS = [];
        $GLOBALS['bug_78961'] = [];
        $GLOBALS['bug_78961']['nsno'] = 3;
        if(!isset($GLOBALS['bug_78961']['nsno']))
        {
         trigger_error('https://bugs.php.net/bug.php?id=78961');
        }
        var_dump($GLOBALS['bug_78961']['nsno']);
    break;
}
 [2019-12-14 15:59 UTC] cmb@php.net
-Summary: switch+opcache +Summary: erroneous optimization of re-assigned $GLOBALS -Status: Open +Status: Verified
 [2019-12-14 15:59 UTC] cmb@php.net 
Due to commit 3ccd3ab[1], CSE optimizes this basically to

    $GLOBALS = array();
    $GLOBALS['td'] = array();
    $td['nsno'] = 3;
    var_dump($GLOBALS['td']['nsno']);

However, $the assignment to $GLOBALS severed the link to the
global variables, so that this optimization can not work.

The switch is irrelevant, by the way.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=3ccd3aba90b4c0c95f1e0a457dbbc33c4524a4ed>
 [2019-12-16 09:04 UTC] nikic@php.net
-Assigned To: +Assigned To: dmitry
 [2019-12-16 09:25 UTC] dmitry@php.net 
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=6ef7e53c1be3670e77394cf9abcc7d9443b2769a
Log: Fixed bug #78961 (erroneous optimization of re-assigned $GLOBALS)
 [2019-12-16 09:25 UTC] dmitry@php.net
-Status: Verified +Status: Closed
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun Oct 27 16:01:27 2024 UTC