php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78495 Allow any functions in ob_start user's callback
Submitted: 2019-09-05 12:34 UTC Modified: 2024-01-25 13:37 UTC
From: michael dot vorisek at email dot cz Assigned: girgias (profile)
Status: Closed Package: Output Control
PHP Version: 7.3.9 OS: Any
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: michael dot vorisek at email dot cz
New email:
PHP Version: OS:

 

 [2019-09-05 12:34 UTC] michael dot vorisek at email dot cz
Description:
------------
Currently the ob_start user's callback is executed in some special context and (at least) these functions behave not as expected:
- ob_end_clean
- exit

The "ob_end_clean" is not supported as "Cannot use output buffering in output buffering display handlers".

But the "exit" should be fully supported as there is no other way to interrupt the code execution and get shutdown handlers executed. Obviously the shutdown handlers should be able to output some data or manipulate with the output buffering.

The desired execution flow be the following:
standard code...
-- ob handler called
---- stop ob handler execution if an exception is thrown or exit is called
-- exit the ob handler context and
   - if an exception was thrown handle the exception as uncaught in global context and
   - exit the main execution, i.e. start processing shutdown handlers as if normal exit was called (if no exit was called yet)

Test script:
---------------
<?php

// capture any unexpected output and exit execution
ob_start(function($buffer) {
    ob_end_clean();
    echo 'unexpected output: ' . $buffer . "\n";
    exit;
}, 1);

// do some work on shutdown
register_shutdown_function(function() {
    echo 'shutting down';
});

echo 'test_1';
echo 'test_2';


Expected result:
----------------
Fatal error: ob_end_clean(): Cannot use output buffering in output buffering display handlers in C:\Users\mvorisek\Desktop\x.php on line 5
shutting down

Actual result:
--------------
unexpected output: test_1
shutting down

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-12-17 18:26 UTC] archon810 at gmail dot com
Possibly related: https://bugs.php.net/bug.php?id=78565.
 [2024-01-07 11:43 UTC] haszika80 at gmail dot com
This has been fixed and produces OP's expected result.
 [2024-01-25 13:37 UTC] girgias@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: girgias
 [2024-01-25 13:37 UTC] girgias@php.net
Thank you for your bug report. This issue has already been fixed
in the latest released version of PHP, which you can download at
http://www.php.net/downloads.php


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Apr 19 01:01:28 2024 UTC