php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78060 Large image sizes don't show properly
Submitted: 2019-05-24 08:56 UTC Modified: 2019-05-24 09:37 UTC
From: petk@php.net Assigned:
Status: Open Package: Website problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: petk@php.net
New email:
PHP Version: OS:

 

 [2019-05-24 08:56 UTC] petk@php.net
Description:
------------
Leftover from my very long TODO list of bugs for these PHP sites - maybe someone who will be fixing these sites will have motivation to fix them.

http://php.net/conferences/

^ here if the image size is too big (let's say 1600x800) there should be limit in CSS to scale such image responsively to a max width.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-05-24 09:27 UTC] salathe@php.net
This should be being caught when reviewing the Pull Requests.  Any PRs with huge images should not be approved until an appropriately-sized image is used instead.

If a commit doesn't go through the review system and a huge image does added to the repo, then I would rather it be displayed as huge so we can notice the issue and get the image resized.
 [2019-05-24 09:30 UTC] petk@php.net
Ok... :) I think that this is wrong approach, but your call here. I don't merge pull requests there so I'm sure you'll catch it on time then.
 [2019-05-24 09:35 UTC] cmb@php.net
Well, we could set up a pre-commit hook where the image size would
be checked.
 [2019-05-24 09:37 UTC] salathe@php.net
I was just trying to clarify what should be the existing process, and gave a personal opinion; not to dictate anything.  I hope we can have differing thoughts and opinions yet still get a productive outcome.
 [2019-05-24 09:50 UTC] petk@php.net
@salathe, absolutely. I've only reported few issues I found along. It's up to you and the rest of the web php people here mainly probably Kalle also what you will do with these reports. There were more but (not related to this ticket but others) I think that only seeing my name here causes conflicts now also. I'll just rm -rf todo.txt and move along. Thanks.
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Wed Feb 26 15:01:29 2020 UTC