php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #77826 xdiff_string_bpatch wrong return value on error
Submitted: 2019-03-30 06:26 UTC Modified: -
From: kentaro at ranvis dot com Assigned:
Status: Open Package: xdiff (PECL)
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please — but make sure to vote on the bug!
Your email address:
MUST BE VALID
Solve the problem:
3 + 46 = ?
Subscribe to this entry?

 
 [2019-03-30 06:26 UTC] kentaro at ranvis dot com
Description:
------------
xdiff_string_patch()/xdiff_string_bpatch() (PECL xdiff 2.0.1-dev's) doesn't return false as documented when broken input is passed.

I will add PR later.

Test script:
---------------
var_dump(xdiff_string_bpatch('123', '123'));


Expected result:
----------------
bool(false)


Actual result:
--------------
string(0) ""


Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-03-30 06:38 UTC]
The following pull request has been associated:

Patch Name:  Fixed bug #77826 (xdiff_string_bpatch wrong return value on error).
On GitHub:  https://github.com/php/pecl-text-xdiff/pull/3
Patch:      https://github.com/php/pecl-text-xdiff/pull/3.patch
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Fri Nov 22 22:01:27 2019 UTC