php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #77826 xdiff_string_bpatch wrong return value on error
Submitted: 2019-03-30 06:26 UTC Modified: 2022-05-24 13:23 UTC
From: kentaro at ranvis dot com Assigned: remi (profile)
Status: Closed Package: *General Issues
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: kentaro at ranvis dot com
New email:
PHP Version: OS:

 

 [2019-03-30 06:26 UTC] kentaro at ranvis dot com 
Description:
------------
xdiff_string_patch()/xdiff_string_bpatch() (PECL xdiff 2.0.1-dev's) doesn't return false as documented when broken input is passed.

I will add PR later.

Test script:
---------------
var_dump(xdiff_string_bpatch('123', '123'));


Expected result:
----------------
bool(false)


Actual result:
--------------
string(0) ""

Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-03-30 06:38 UTC] 
The following pull request has been associated:

Patch Name:  Fixed bug #77826 (xdiff_string_bpatch wrong return value on error).
On GitHub:  https://github.com/php/pecl-text-xdiff/pull/3
Patch:      https://github.com/php/pecl-text-xdiff/pull/3.patch
 [2022-05-24 13:23 UTC] remi@php.net
-Status: Open +Status: Closed -Package: xdiff +Package: *General Issues -Assigned To: +Assigned To: remi
 [2022-05-24 13:23 UTC] remi@php.net 
Fixed
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Apr 20 06:01:28 2024 UTC