php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #77290 asXML - fist argument behavior
Submitted: 2018-12-12 18:18 UTC Modified: 2020-03-10 11:00 UTC
From: lagodichyuriy at gmail dot com Assigned: cmb (profile)
Status: Closed Package: SimpleXML related
PHP Version: 7.2.13 OS: Archlinux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
35 + 42 = ?
Subscribe to this entry?

 
 [2018-12-12 18:18 UTC] lagodichyuriy at gmail dot com
Description:
------------
Current asXML() behavior of the SimpleXMLElement object is not really neat: this method may accept "filename" as a first argument for data storing on a HDD. 

However, if a "filename" is empty (let's say "null" or empty string), this method will throw a warning about it.

This logic asks from the programmer create very strange structures to avoid such warning messages: "if ($filename) { return $xml->asXML($filename); } else { return $xml->asXML(); }"

Test script:
---------------
<?php

function example($file_path = null)
{
	$xml = new \SimpleXMLElement('<data></data>');

	return $xml->asXML($file_path);

}

example(); # will throw "PHP Warning:  SimpleXMLElement::asXML(): Filename cannot be empty in ..."

Expected result:
----------------
I suggest to make a "filename" as an optional argument for this method.

Actual result:
--------------
PHP Warning: SimpleXMLElement::asXML(): Filename cannot be empty in ...

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-12-12 19:26 UTC] Wes dot example at example dot org
I agree with you.
The function implementation must not be aware on whether the argument was filled in automatically or actually specified at call time by developer. Defining behavior depending on whether the argument was explicitly specified or not is just terrible. Unfortunately this happens everywhere in PHP, it's not just this function
 [2020-03-10 11:00 UTC] cmb@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: cmb
 [2020-03-10 11:00 UTC] cmb@php.net
This feature request is already implemented in the master branch[1].

[1] <https://github.com/php/php-src/commit/743d27631fa600f071d4b3b1cf061708a9866f5b>
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Jul 19 18:01:30 2024 UTC