php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #77217 FILTER_FLAG_NO_RES_RANGE means Reserved-By-Protocol
Submitted: 2018-11-29 02:25 UTC Modified: 2018-11-29 19:41 UTC
From: dan dot franklin at fen dot com Assigned:
Status: Open Package: Filter related
PHP Version: 7.1.24 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: dan dot franklin at fen dot com
New email:
PHP Version: OS:

 

 [2018-11-29 02:25 UTC] dan dot franklin at fen dot com
Description:
------------
According to https://en.wikipedia.org/wiki/Reserved_IP_addresses the IPv4 address range 100.64.0.0/10 is reserved for carrier-grade NAT.  But in PHP 7.1.24 filter_var with FILTER_FLAG_NO_RES_RANGE thinks it's fine.



Test script:
---------------
<?php
var_export(filter_var('100.74.11.184', FILTER_VALIDATE_IP, FILTER_FLAG_NO_RES_RANGE));


Expected result:
----------------
false

Actual result:
--------------
'100.74.11.184'


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-11-29 02:41 UTC] requinix@php.net
-Summary: FILTER_FLAG_NO_RES_RANGE should match 100.64.0.0/10 +Summary: FILTER_FLAG_NO_RES_RANGE means Reserved-By-Protocol -Type: Bug +Type: Documentation Problem -Package: Unknown/Other Function +Package: Filter related
 [2018-11-29 02:41 UTC] requinix@php.net
FILTER_FLAG_NO_RES_RANGE refers specifically to ranges marked as Reserved-By-Protocol in RFC 6890, which covers the addresses mentioned in the documentation. What Wikipedia labels as "reserved" is really more about the range having a special meaning.

If anything, 100./10 would be part of the the PRIV_RANGE, except the range isn't entirely private. Debatable.
 [2018-11-29 14:34 UTC] dan dot franklin at fen dot com
Thanks for the explanation.  Unfortunately this means that the two current IP validation flags don't meet my needs.  Seems like there needs to be a new flag FILTER_FLAG_GLOBAL_RANGE which rejects IP addresses that are marked as "Global: false" in RFC 6890 (amended to "Global Reach" in RFC 8190).
 [2018-11-29 17:07 UTC] requinix@php.net
> Seems like there needs to be a new flag FILTER_FLAG_GLOBAL_RANGE
Sounds reasonable. Please create a feature request for it so this bug report can be about fixing the documentation for FILTER_FLAG_NO_RES_RANGE.

Though maybe it should be "FILTER_FLAG_NO_GLOBAL_RANGE".
 [2018-11-29 19:41 UTC] dan dot franklin at fen dot com
Thanks, I've submitted a feature request.
https://bugs.php.net/bug.php?id=77221&thanks=4

I would expect a flag NO_GLOBAL_RANGE to _exclude_ global addresses, as NO_RES_RANGE excludes reserved addresses and NO_PRIV_RANGE excludes private addresses.  I suggested FILTER_FLAG_ONLY_GLOBAL_RANGE in my feature request.
 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Tue Dec 11 23:01:25 2018 UTC