php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #76893 Typos in ".inc" files in "ext/spl/internal"
Submitted: 2018-09-17 00:30 UTC Modified: 2018-09-17 06:09 UTC
From: ejrx7753 at gmail dot com Assigned: nikic (profile)
Status: Closed Package: SPL related
PHP Version: 7.3.0 OS: Irrelevant
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: ejrx7753 at gmail dot com
New email:
PHP Version: OS:

 

 [2018-09-17 00:30 UTC] ejrx7753 at gmail dot com
Description:
------------
Just to be clear, this is a cosmetic issue with no demonstrated harm, but there are some apparent typos in "ext/spl/internal/splobjectstorage.inc" and "ext/spl/internal/recursivecachingiterator.inc".

Typos are of a few categories:
- misnamed methods
- extra colons
- missing colons

I'm not sure what these files are used for exactly, but I ran them as PHP and all of them parse file except for these 4-line exceptions. I'm sure whatever build process if any uses these .inc does not care about theses issues, but these are clearly PHP code files.

Details:

splobjectstorage.inc


--- offsetEsists should be "offsetExists"
--- missing commas at end of "current" and "getInfo"

recursivecachingiterator.inc

"function rewind();" is not abstract, but has a colon


Git links:
https://github.com/php/php-src/blob/PHP- 7.3/ext/spl/internal/splobjectstorage.inc
https://github.com/php/php-src/blob/PHP-7.3/ext/spl/internal/recursivecachingiterator.inc




Test script:
---------------
n/a

Expected result:
----------------
n/a

Actual result:
--------------
n/a

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-09-17 00:49 UTC] ejrx7753 at gmail dot com
Additionally, "spl/internal/cachingiterator.inc" CachingIterator::__construct uses two class constants not defined: self::CIT_TOSTRING_USE_KEY and self::CIT_TOSTRING_USE_CURRENT.
 [2018-09-17 02:16 UTC] carusogabriel@php.net
We've already dropped the SPL documentation in the master branch: http://git.php.net/?p=php-src.git;a=commit;h=9003d8a4, as it was outdated, and the one at https://php.net/spl should be used instead.

The links you provide were from PHP-7.3 branch, so, I believe this bug can be closed as "Won't fix".
 [2018-09-17 02:55 UTC] carusogabriel@php.net
-Type: Bug +Type: Documentation Problem -Operating System: any +Operating System: Irrelevant -PHP Version: 7.2.10 +PHP Version: 7.3.0
 [2018-09-17 06:09 UTC] nikic@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: nikic
 [2018-09-17 06:09 UTC] nikic@php.net
Indeed, this issue has been "fixed" by deleting the files in master :)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Dec 03 08:01:28 2024 UTC