php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76889 checkdnsrr.phpt fails because bugs.php.net doesn't have all 12 DNS records
Submitted: 2018-09-16 14:27 UTC Modified: 2018-10-06 14:56 UTC
From: spam2 at rhsoft dot net Assigned: pmmaga (profile)
Status: Closed Package: Testing related
PHP Version: 7.2Git-2018-09-16 (Git) OS: Fedora 28
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
40 - 22 = ?
Subscribe to this entry?

 
 [2018-09-16 14:27 UTC] spam2 at rhsoft dot net
Description:
------------
FAILED TEST SUMMARY
---------------------------------------------------------------------
bool checkdnsrr ( string $host [, string $type = "MX" ] ); [ext/standard/tests/checkdnsrr.phpt]

that test now fails for months - why do such issues not get fixed or non-working tests not disabled so that it's easier for the maintainers to fix remaining ones?


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-09-16 15:24 UTC] requinix@php.net
-Summary: checkdnsrr.phpt fails +Summary: checkdnsrr.phpt fails because bugs.php.net doesn't have all 12 DNS records
 [2018-09-16 15:24 UTC] requinix@php.net
Thanks for reporting this months ago when you first saw it was broken.

checkdnsrr is working fine but it's testing against bugs.php.net which doesn't have all the record types it wants. I checked a few big name domains and they too generally have about half of them. I did find ipv6.comcast.net had all 12, but it wouldn't be fair to borrow their domain.
I think the answer here is taking some php.net domain, like bugs.php.net or some new subdomain, and just giving it all these records purely for the sake of testing. Could be in Jan 2017 when the test was first added that it did have everything, but apparently not anymore.
 [2018-09-16 15:27 UTC] spam2 at rhsoft dot net
> Thanks for reporting this months ago when you first saw it was broken

don't get me wrong but i thought the php-developers are running their test-suite regulary at their own and look at every faling test as i do all the time with my tests
 [2018-10-05 00:14 UTC] pmmaga@php.net
-Status: Open +Status: Verified
 [2018-10-05 00:14 UTC] pmmaga@php.net
I've opened a PR switching it to use php.net and matching the currently existing records. https://github.com/php/php-src/pull/3577
 [2018-10-06 14:56 UTC] pmmaga@php.net
-Status: Verified +Status: Closed -Assigned To: +Assigned To: pmmaga
 [2018-10-06 14:56 UTC] pmmaga@php.net
The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.

The unstable test was removed.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Sat Nov 16 22:01:35 2019 UTC