php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76820 Z_COPYABLE invalid definition
Submitted: 2018-08-30 15:24 UTC Modified: 2018-08-30 15:49 UTC
From: mvdwerve at outlook dot com Assigned: cmb (profile)
Status: Closed Package: *General Issues
PHP Version: master-Git-2018-08-30 (Git) OS: All
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: mvdwerve at outlook dot com
New email:
PHP Version: OS:

 

 [2018-08-30 15:24 UTC] mvdwerve at outlook dot com
Description:
------------
As of commit 742d5a01ed5bd39a18929c04a5f5c5596a4b005b, IS_TYPE_COPYABLE was apparantly removed. We use that in our wrapper of the Zend engine. Although it is deprecated, a good definition should be provided, right? 

https://github.com/php/php-src/blob/master/Zend/zend_types.h#L593
https://github.com/php/php-src/blob/master/Zend/zend_types.h#L613

Currently, it simply doesn't compile when you use the macro and don't include an _extra_ closing bracket, as this is the current definition in master:

#define Z_COPYABLE(zval)			((Z_TYPE(zval) == IS_ARRAY)

where it should be 

#define Z_COPYABLE(zval)			(Z_TYPE(zval) == IS_ARRAY)



Patches

definition_fix (last revision 2018-08-30 15:24 UTC by mvdwerve at outlook dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-08-30 15:49 UTC] cmb@php.net
-Status: Open +Status: Verified -Assigned To: +Assigned To: cmb
 [2018-08-30 15:49 UTC] cmb@php.net
Thanks!
 [2018-08-30 16:02 UTC] cmb@php.net
Automatic comment on behalf of cmbecker69@gmx.de
Revision: http://git.php.net/?p=php-src.git;a=commit;h=c5231ad394fa3a6c59b9786af977d61da3f1e208
Log: Fix #76820: Z_COPYABLE invalid definition
 [2018-08-30 16:02 UTC] cmb@php.net
-Status: Verified +Status: Closed
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Mon Aug 26 01:01:26 2019 UTC