php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #76314 Specify failure return type for soundex
Submitted: 2018-05-09 01:25 UTC Modified: 2018-05-09 13:03 UTC
From: roy-orbison at devo dot net dot au Assigned:
Status: Open Package: Strings related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: roy-orbison at devo dot net dot au
New email:
PHP Version: OS:

 

 [2018-05-09 01:25 UTC] roy-orbison at devo dot net dot au
Description:
------------
---
From manual page: http://www.php.net/function.soundex
---

No mention that it returns FALSE on failure.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-05-09 01:31 UTC] requinix@php.net
-Summary: Specify failure return type. +Summary: Specify failure return type for soundex -Package: Documentation problem +Package: Strings related
 [2018-05-09 01:31 UTC] requinix@php.net
...which only happens if the string is empty.
 [2018-05-09 01:40 UTC] roy-orbison at devo dot net dot au
Or a 0, or false, or null.

Or, if it gets an array (but only an array), it emits a warning and returns NULL.

There are plenty of ways bad data can be passed to a function, return types should be consistent and documented.
 [2018-05-09 01:46 UTC] requinix@php.net
http://php.net/manual/en/functions.internal.php
> Note: If the parameters given to a function are not what it expects, such as passing an array where a string is
> expected, the return value of the function is undefined. In this case it will likely return NULL but this is just a
> convention, and cannot be relied upon.
 [2018-05-09 02:07 UTC] roy-orbison at devo dot net dot au
Then why bother specifying return value(s) upon failure on other functions?
 [2018-05-09 13:03 UTC] requinix@php.net
Because accidentally trying to soundex an empty string (or something convertable to a string) is understandable but calling it with an array doesn't make sense and suggests possible developer error?
 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Fri Oct 19 16:01:25 2018 UTC