php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76028 call_user_func($a) and $a() behave differently
Submitted: 2018-02-28 14:33 UTC Modified: 2018-02-28 17:54 UTC
From: bburnichon at gmail dot com Assigned:
Status: Open Package: Scripting Engine problem
PHP Version: 7.1 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: bburnichon at gmail dot com
New email:
PHP Version: OS:

 

 [2018-02-28 14:33 UTC] bburnichon at gmail dot com
Description:
------------
A callable can be defined as an array containing class and method.

Calling call_user_func() with such an array has no issue.
If you try to use the array as a callable, then 'self' loose its special meaning and an error is triggered saying class self does not exists.

Test script:
---------------
<?php

class CallBySelf
{
    public static function foo()
    {
        echo 'Foo', PHP_EOL;
    }
    
    public static function testCall()
    {
        $method = ['self', 'foo'];
        var_dump(is_callable($method));
        
        echo 'Call via call_user_func: ';
        call_user_func($method);
        
        echo 'Direct call: ';
        $method();
    }
}

CallBySelf::testCall();

Expected result:
----------------
Call via call_user_func: Foo
Direct call: Foo


Actual result:
--------------
bool(true)
Call via call_user_func: Foo
Direct call: 
Fatal error: Class 'self' not found in /in/Ssgep on line 19


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-02-28 14:38 UTC] bburnichon at gmail dot com
Checked versions having the issue with 3v4l.org: https://3v4l.org/Ssgep
 [2018-02-28 15:24 UTC] requinix@php.net
-Package: PHP Language Specification +Package: Scripting Engine problem -PHP Version: 5.6.33 +PHP Version: 7.1
 [2018-02-28 17:39 UTC] cmb@php.net
FWIW: don't use the string 'self', but rather self::class,
see <https://3v4l.org/Xkkuf>.
 [2018-02-28 17:54 UTC] bburnichon at gmail dot com
Yes, that's what I've done once I discovered the issue. I just wished I knew this before. I've learnt it the hard way while refactoring an old class which was calling 

```
$method = // Method from user input
$callable = ['self', $method];
if (is_callable($callable)) {
  call_user_func($callable);
}
```

to 

```
$method = // Whitelisted method
$callable = [self::class, $method];
$callable();
```
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Thu May 23 10:01:29 2019 UTC