php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #75267 php-7.1.10/ext/opcache/Optimizer/zend_dump.c:693: possible &/&& mixup ?
Submitted: 2017-09-27 10:01 UTC Modified: -
From: dcb314 at hotmail dot com Assigned:
Status: Closed Package: opcache
PHP Version: 7.1.10RC1 OS: linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: dcb314 at hotmail dot com
New email:
PHP Version: OS:

 

 [2017-09-27 10:01 UTC] dcb314 at hotmail dot com
Description:
------------
php-7.1.10/ext/opcache/Optimizer/zend_dump.c:693]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is

   if (!(dump_flags & ZEND_DUMP_HIDE_UNREACHABLE) & !(b->flags & ZEND_BB_REACHABLE)) {

Maybe better code

   if (!(dump_flags & ZEND_DUMP_HIDE_UNREACHABLE) && !(b->flags & ZEND_BB_REACHABLE)) {



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-09-29 03:18 UTC] laruence@php.net
Automatic comment on behalf of laruence@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=9fd33c1f20a95c5cdbc7c161708ef0db6156877e
Log: Fixed bug #75267 (possible &/&& mixup)
 [2017-09-29 03:18 UTC] laruence@php.net
-Status: Open +Status: Closed
 
PHP Copyright © 2001-2022 The PHP Group
All rights reserved.
Last updated: Thu Sep 29 18:03:43 2022 UTC