php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #74937 configure script does check for host_alias at wrong location
Submitted: 2017-07-17 10:15 UTC Modified: 2017-07-30 04:22 UTC
From: venkatunix02 at gmail dot com Assigned: ab (profile)
Status: No Feedback Package: *Configuration Issues
PHP Version: Irrelevant OS: any
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: venkatunix02 at gmail dot com
New email:
PHP Version: OS:

 

 [2017-07-17 10:15 UTC] venkatunix02 at gmail dot com 
Description:
------------
 configure script current defines different variable to identify host OS(AIX, HPUX, LINUX etc) inside the code for checking "Birdstep" as mentioned below in configure of 7.2 alpha. 

54873    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for Birdstep support" >&5
 54874  $as_echo_n "checking for Birdstep support... " >&6; }
 54875    if test "$PHP_BIRDSTEP" != "no"; then
 54876      if test "$PHP_BIRDSTEP" = "yes"; then
 54877          ODBC_INCDIR=/usr/local/birdstep/include
 54878          ODBC_LIBDIR=/usr/local/birdstep/lib
 54879      else
 54880          ODBC_INCDIR=$PHP_BIRDSTEP/include
 54881          ODBC_LIBDIR=$PHP_BIRDSTEP/$PHP_LIBDIR
 54882      fi
 54883
 54884      case $host_alias in
 54885        *aix*)
 54886
 54887  $as_echo "#define AIX 1" >>confdefs.h
 54888  ;;
 54889        *hpux*)
 54890
 54891  $as_echo "#define HPUX 1" >>confdefs.h
 54892  ;;
 54893        *linux*)
 54894
 54895  $as_echo "#define LINUX 1" >>confdefs.h
 54896  ;;
 54897        *qnx*)
 54898
 54899  $as_echo "#define NEUTRINO 1" >>confdefs.h
 54900  ;;
 54901        i?86-*-solaris*)
 54902
 54903  $as_echo "#define ISOLARIS 1" >>confdefs.h
 54904  ;;
 54905        sparc-*-solaris*)
 54906
 54907  $as_echo "#define SOLARIS 1" >>confdefs.h
 54908  ;;
 54909        *unixware*)
 54910
 54911  $as_echo "#define UNIXWARE 1" >>confdefs.h
 54912  ;;
 54913      esac
 54914
 54915      ODBC_INCLUDE=-I$ODBC_INCDIR
 54916      ODBC_TYPE=birdstep
 54917      ODBC_LFLAGS=-L$ODBC_LIBDIR
 54918      ODBC_LIBS="-lCadm -lCdict -lCenc -lCrdm -lCrpc -lCrdbc -lCrm -lCuapi -lutil"
 54919
 54920      if test -f "$ODBC_LIBDIR/libCrdbc32.$SHLIB_SUFFIX_NAME"; then
 54921        ODBC_LIBS="-lCrdbc32 -lCadm32 -lCncp32 -lCrm32 -lCsql32 -lCdict32 -lCrdm32 -lCrpc32 -lutil"
 54922      elif test -f "$ODBC_LIBDIR/libCrdbc.$SHLIB_SUFFIX_NAME"; then
 54923        ODBC_LIBS="-lCrdbc -lCadm -lCncp -lCrm -lCsql -lCdict -lCrdm -lCrpc -lutil"
 54924      fi
 

can we move that outside above block so that those settings can be made always and we can use those macros to write platform specific code.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-07-19 08:51 UTC] kalle@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: ab
 [2017-07-19 08:51 UTC] kalle@php.net 
I have removed Birdstep support from master (PHP 7.3.0), Anatol, can you clarify this one for lower branches?
 [2017-07-19 09:50 UTC] ab@php.net
-Status: Assigned +Status: Feedback
 [2017-07-19 09:50 UTC] ab@php.net 
It's not about birdstep, actually. 

@venkatunix02, i guess what you want is to expand on PHP_OS_FAMILY. It is slightly more than just moving the code into the global space, please check how PHP_OS_FAMILY is currently checked. In some cases some generalized macro for say BSD makes sense, whereby often an exact flavour check is required. Or what is the approach you have in mind? Maybe a patch?

Thanks.
 [2017-07-30 04:22 UTC] php-bugs at lists dot php dot net 
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 26 00:01:30 2024 UTC