php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #73961 Build issue in hash_sha3.c
Submitted: 2017-01-19 18:38 UTC Modified: -
From: j dot david dot lists at gmail dot com Assigned:
Status: Closed Package: hash related
PHP Version: 7.1.1 OS: FreeBSD
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: j dot david dot lists at gmail dot com
New email:
PHP Version: OS:

 

 [2017-01-19 18:38 UTC] j dot david dot lists at gmail dot com
Description:
------------
In our local build of PHP, we ran into a compile error on hash_sha3.c.

hash_sha3.c includes php_hash_sha3.h which includes "ext/hash/php_hash.h" which is not valid.

This is corrected by the attached (trivial) patch, which changes hash_sha3.c to be like the other files in the extension, which include php_hash.h first.  Doing so eliminates the environmental build dependency.






Patches

php_hash_sha3.patch (last revision 2017-01-19 18:38 UTC by j dot david dot lists at gmail dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-01-21 07:47 UTC] krakjoe@php.net
Automatic comment on behalf of krakjoe
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1ff27053f9ffc7c68cf71b6cfb072583e2e7a610
Log: Fix bug #73961 environmental build dependency in hash sha3 source
 [2017-01-21 07:47 UTC] krakjoe@php.net
-Status: Open +Status: Closed
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Sat Sep 21 23:01:27 2019 UTC