php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #73872 Static method variable state depends on file include
Submitted: 2017-01-05 13:34 UTC Modified: 2021-02-18 10:57 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: sc at shpock dot com Assigned: nikic (profile)
Status: Closed Package: Class/Object related
PHP Version: 7.0.14 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
31 - 1 = ?
Subscribe to this entry?

 
 [2017-01-05 13:34 UTC] sc at shpock dot com
Description:
------------
Setup: a parent class which defines a static variable in a method. The static variable is initialized with NULL and set to some value on the first method call. Then, a child class calls the same (inherited) method.

If the child class definition is in the same file as the parent class definition, this works as expected. However, if the child class definition is loaded from a separate file and this file is loaded after(!) the first call to the method which sets the static variable, the static variable seems to be "shared" between both classes.

I'm really curious about an explanation in case this is not a bug because i would like to understand the concept. Thank you!

Test script:
---------------
class ParentClass
{
    protected $something = 'parent';
    public function getSomething()
    {
        static $cache;
        return $cache !== null
            ? $cache
            : $cache = $this->something;
    }
}


$parent = new ParentClass();
var_dump($parent->getSomething()); // expected: 'parent'; returned: 'parent'

include 'child.php';
# content of child.php:
//class ChildClass extends ParentClass
//{
//    protected $something = 'child';
//}

$child = new ChildClass();
var_dump($child->getSomething()); // expected 'child'; returned 'parent'


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-02-18 10:57 UTC] nikic@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: nikic
 [2021-02-18 10:57 UTC] nikic@php.net
This issue has been fixed in PHP 8.1 with https://github.com/php/php-src/commit/5d160e309ed207e618d49029e51c9c2dc2c5e61c.

The reason why the include makes a difference is that without the include, the CihldClass is early bound, which means that it is actually registered before the call to $parent->getSomething().

After the aforementioned fix, the call to getSomething() no longer influences the behavior.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Mar 29 10:01:28 2024 UTC