php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #71364 restore_error_handler() should return the actual callable
Submitted: 2016-01-14 03:01 UTC Modified: -
From: hujuice at inservibile dot org Assigned:
Status: Open Package: Unknown/Other Function
PHP Version: 5.6Git-2016-01-14 (snap) OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please — but make sure to vote on the bug!
Your email address:
MUST BE VALID
Solve the problem:
29 + 43 = ?
Subscribe to this entry?

 
 [2016-01-14 03:01 UTC] hujuice at inservibile dot org
Description:
------------
restore_error_handler() returns always true, no info.
But in complex situations where included files could add other handlers, there's no way to be sure that the restored handler is the wanted one.

This doubt could be prevented if restore_error_handler() would return the actual callable or null if at the end of the stack.


Test script:
---------------
file1.php
=========
<?php
set_error_handler('someFunct');
include 'file2.php';
restore_error_handler(); // Not enough!

file2.php
=========
<?php
set_error_handler('anotherFunct');

Expected result:
----------------
NOT CORRECT! It could be an useful feature

file1.php
=========
<?php
$prev = set_error_handler('someFunct');
include 'file2.php';
do {
   $actual = restore_error_handler(); // Run twice
} while ($actual != $prev);

file2.php
=========
<?php
set_error_handler('anotherFunct');


Patches

Add a Patch

Pull Requests

Add a Pull Request

 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Apr 19 12:01:27 2024 UTC