php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #70839 Convertion optional argument to variadic forbidden by LSP checks
Submitted: 2015-11-02 16:48 UTC Modified: 2015-11-02 17:04 UTC
From: nikic@php.net Assigned: nikic (profile)
Status: Assigned Package: Scripting Engine problem
PHP Version: 5.6.16 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: nikic@php.net
New email:
PHP Version: OS:

 

 [2015-11-02 16:48 UTC] nikic@php.net
Description:
------------
Should be allowed and was allowed in 5.6. Off by one error caused by the variadic parameter no longer counting as an argument.

Test script:
---------------
class Foo {
    public function test($bar = null) {}
}

class Baz extends Foo {
    public function test(...$args) {}
}



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-11-02 16:49 UTC] nikic@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: nikic
 [2015-11-02 17:04 UTC] nikic@php.net
-PHP Version: 7.0.0RC6 +PHP Version: 5.6.16
 [2015-11-02 17:04 UTC] nikic@php.net
Actually this issue also exists in PHP 5.6 if you have more than one optional parameter:

class Foo {
    public function test($foo = null, $bar = null) {}
}

class Baz extends Foo {
    public function test(...$args) {}
}

The fact that it worked for one was just an accident that PHP 7 fixed.

We should allow changing any number of optional arguments to a variadic one in both 5.6 and 7.0.
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Sun Nov 19 01:31:42 2017 UTC