php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #69706 getimagesize() can fail if the underlying stream doensn't support seeking
Submitted: 2015-05-25 18:29 UTC Modified: -
Votes:10
Avg. Score:4.3 ± 0.9
Reproduced:8 of 8 (100.0%)
Same Version:4 (50.0%)
Same OS:2 (25.0%)
From: deviantintegral at gmail dot com Assigned:
Status: Open Package: GetImageSize related
PHP Version: 5.6.9 OS: Any
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: deviantintegral at gmail dot com
New email:
PHP Version: OS:

 

 [2015-05-25 18:29 UTC] deviantintegral at gmail dot com 
Description:
------------
I've verified this is an issue on PHP 5.4, 5.6, and statically on the master branch.

The AWS SDK (https://aws.amazon.com/sdk-for-php/) includes a stream wrapper that by default does not support seeking on files backed by S3. Calling getimagesize() on an image can fail if php_skip_variable() is called. I've seen this happen with images that specify the "Image Quality" EXIF tag, which is the M_APP15 constant in ext/standard/image.c.

The stream documentation states that seeking is not required to be supported by stream wrappers, and it's not clear that getimagesize() needs seeking to work properly.

I see two ways to improve this:

* Log a notice if php_skip_variable() tries to seek on an unseekable stream. That would have saved me a ton of time tracing this with GDB.
* Or, if a stream is not seekable, copy the file to the temporary file system and fetch metadata from there.

Patches

Add a Patch

Pull Requests

Add a Pull Request
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved. 		Last updated: Fri Nov 15 20:01:39 2019 UTC