php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #69351 recursive mkdir fails with parent (dot dot) directory in path and symlink
Submitted: 2015-04-01 22:18 UTC Modified: -
From: dave2008 at buchananville dot net Assigned:
Status: Open Package: Directory function related
PHP Version: 5.4.39 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: dave2008 at buchananville dot net
New email:
PHP Version: OS:

 

 [2015-04-01 22:18 UTC] dave2008 at buchananville dot net
Description:
------------
Running recursive mkdir fails when there is a ".." directory in the path, and a symbolic link is present:

mkdir('a/d/../e',0755,true);

The problem is that it is is expanding the path string in place instead of following the physical filesystem.  After it traverses into a/d, the ".." directory actually takes you somewhere else.  Not to "a".  In bash this is like `cd -P`.

It worked like this in previous versions (at least on PHP 5.3.3 and before).

Where previous versions of PHP have acted this way, I think it is best for backwards compatibility for this to work.


It looks like this was broken when the fix for bug #55124 was applied:

it made it use expand_filepath_with_mode() with the CWD_EXPAND.  Maybe it should have used CWD_REALPATH instead?  Just a guess...

Test script:
---------------
<?php

mkdir('a/b/c',0755,true);
symlink('b/c','a/d');
chmod('a',0555);

mkdir('a/d/../e',0755,true);

Expected result:
----------------
On PHP 5.3.3 it runs with no output

Actual result:
--------------
PHP Warning:  mkdir(): Permission denied in /var/autofs/home/dave/test-recursive-mkdir.php on line 7

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-10-26 19:42 UTC] nemecek at wienfluss dot net
I was investigating this issue for a CMS we use and can confirm the problem for the following PHP versions:
* 5.4.16
* 5.4.30
* 5.4.38
* 5.4.44
* 5.4.45
* 5.5.14
* 5.5.22
* 5.5.26
* 5.5.28
* 5.5.30
* 5.5.35
* 5.6.0
* 5.6.2
* 5.6.6
* 5.6.12
* 5.6.16
* 5.6.21
* 7.0.6


JFTR:
In the described test case, the call "mkdir('a/d/../e',0755,false);" would correctly create the path.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Mon Nov 18 21:01:37 2019 UTC