php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #68843 Incorrect expression?
Submitted: 2015-01-16 07:27 UTC Modified: 2015-01-18 03:31 UTC
From: bugreports at internot dot info Assigned:
Status: Not a bug Package: *General Issues
PHP Version: master-Git-2015-01-16 (Git) OS: Linux Ubuntu 14.04
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: bugreports at internot dot info
New email:
PHP Version: OS:

 

 [2015-01-16 07:27 UTC] bugreports at internot dot info 
Description:
------------
Hi,

main/streams/streams.c:235:		zend_hash_str_del(FG(wrapper_errors), (const char*)&wrapper, sizeof(wrapper));

ext/phar/phar_object.c:1378:		zend_hash_str_del(&PHAR_GLOBALS->phar_persist_map, (const char *) phar_obj->archive, sizeof(phar_obj->archive));


Should there be a -1 after the sizeof? That's how all other uses of zend_hash_str_del is used.


Thanks,

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-01-18 03:31 UTC] laruence@php.net
-Status: Open +Status: Not a bug
 [2015-01-18 03:31 UTC] laruence@php.net 
nope, it depends what you used while putted it into hashtable, they are use sizeof for adding, then it's correct to use sizeof for fetching too
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Mon Apr 29 15:01:31 2024 UTC