php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #67553 Add SIGHUP as a reload signal
Submitted: 2014-07-02 10:12 UTC Modified: -
Votes:19
Avg. Score:4.8 ± 0.5
Reproduced:17 of 18 (94.4%)
Same Version:11 (64.7%)
Same OS:15 (88.2%)
From: ondrej@php.net Assigned:
Status: Open Package: FPM related
PHP Version: 5.4.30 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: ondrej@php.net
New email:
PHP Version: OS:

 

 [2014-07-02 10:12 UTC] ondrej@php.net
Description:
------------
Both upstart and systemd are using SIGHUP as a default signal for reload action and the init scripts needs special configuration because FPM uses SIGUSR2 for reload.

Since SIGHUP is unused in FPM there's no harm in adding it as another reload signal.

Patch attached.

Applies to all supported versions of PHP.

Test script:
---------------
service php5-fpm reload

Expected result:
----------------
PHP FPM reloaded

Actual result:
--------------
PHP FPM in invalid state - main process crashed without killing children processes.

Patches

php5-fpm-do-reload-on-SIGHUP.patch (last revision 2014-07-02 10:12 UTC by ondrej@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-07-02 10:12 UTC] ondrej@php.net
The following patch has been added/updated:

Patch Name: php5-fpm-do-reload-on-SIGHUP.patch
Revision:   1404295970
URL:        https://bugs.php.net/patch-display.php?bug=67553&patch=php5-fpm-do-reload-on-SIGHUP.patch&revision=1404295970
 [2014-07-09 08:46 UTC] remi@php.net
Currently, in provided php-fpm.service we have 

   ExecReload=/bin/kill -USR2 $MAINPID

So no issue encountered with "service php-fpm reload"

But, I think this change can make things more consistent.
 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Mon Dec 17 02:01:26 2018 UTC