php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #67177 run-tests.php doesn't work well with LEAK
Submitted: 2014-05-02 07:00 UTC Modified: 2017-10-24 04:34 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:0 (0.0%)
Same OS:0 (0.0%)
From: nikic@php.net Assigned:
Status: Analyzed Package: Testing related
PHP Version: 5.6.0beta2 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: nikic@php.net
New email:
PHP Version: OS:

 

 [2014-05-02 07:00 UTC] nikic@php.net
Description:
------------
 * REPORT_EXIT_STATUS=1 results in exit=0 even though there are FAILED&LEAKED tests.
 * There is no --show-mem or --show-leak option.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-05-02 07:28 UTC] tyrael@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: tyrael
 [2014-05-02 07:28 UTC] tyrael@php.net
FAILED tests should fail the execution when REPORT_EXIT_STATUS=1 is set, could you show an exemple where that doesn't work?
when you call run-tests.php with -m, it will mark the leaking tests as LEAKED, which isn't FAILED, so that won't result in a non-zero exit status.
--show-mem sounds reasonable, and --show-all should also show the .mem if there is one.
 [2014-05-02 10:29 UTC] nikic@php.net
@tyrael: A LEAK&FAIL test is only counted towards the number of leaked tests, but not towards the number of failed tests (otherwise it would be counted twice). That's why exit status will be 0 even though there were failed tests (that also happened to have memory errors).
 [2014-07-02 19:56 UTC] tyrael@php.net
-Status: Feedback +Status: Assigned
 [2017-10-24 04:34 UTC] kalle@php.net
-Status: Assigned +Status: Analyzed -Assigned To: tyrael +Assigned To:
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Wed Oct 23 15:01:31 2019 UTC