php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #66595 apache2filter was neglected
Submitted: 2014-01-28 12:12 UTC Modified: 2014-04-10 04:00 UTC
From: ondrej@php.net Assigned: mike (profile)
Status: Closed Package: Compile Failure
PHP Version: 5.6.0alpha1 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: ondrej@php.net
New email:
PHP Version: OS:

 

 [2014-01-28 12:12 UTC] ondrej@php.net 
Description:
------------
Apparently nobody has tested apache2filter SAPI when doing 5.6.0alpha1 release, so it doesn't build since sapi_request_info *post_data* has been removed.

Unfortunately this is beyond my PHP internals knowledge, so somebody else needs to fix this.

Expected result:
----------------
apache2filter compiled

Actual result:
--------------
/tmp/buildd/php5-5.6.0~alpha1+dfsg/sapi/apache2filter/sapi_apache2.c: In function 'php_apache_request_ctor':
/tmp/buildd/php5-5.6.0~alpha1+dfsg/sapi/apache2filter/sapi_apache2.c:416:18: error: 'sapi_request_info' has no member named 'post_data'
  SG(request_info).post_data = ctx->post_data;
                  ^
/tmp/buildd/php5-5.6.0~alpha1+dfsg/sapi/apache2filter/sapi_apache2.c:417:18: error: 'sapi_request_info' has no member named 'post_data_length'
  SG(request_info).post_data_length = ctx->post_len;
                  ^

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-01-29 08:33 UTC] tyrael@php.net
-Assigned To: +Assigned To: mike
 [2014-01-29 08:33 UTC] tyrael@php.net 
Mike, could you look into this please?
 [2014-03-24 16:55 UTC] mike@php.net
-Status: Assigned +Status: Closed
 [2014-03-24 16:55 UTC] mike@php.net 
Felt like like a lot of wasted time:
http://git.php.net/?p=php-src.git;a=commit;h=275b2c420dfdd6056e465d6be2256a94227c9df5
 [2014-04-10 04:00 UTC] tyrael@php.net 
thanks!
I can feel your pain, but as long as we have this SAPI in the core, we have to support it.
Make sure we don't forget discussing the removal of the old SAPIs when kicking off the next major.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Apr 25 22:01:29 2024 UTC