php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #66576 phpdbg must link -lreadline during build
Submitted: 2014-01-25 15:10 UTC Modified: 2014-05-06 23:31 UTC
From: rainer dot jung at kippdata dot de Assigned: krakjoe (profile)
Status: Closed Package: phpdbg
PHP Version: 5.6.0alpha1 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
7 + 2 = ?
Subscribe to this entry?

 
 [2014-01-25 15:10 UTC] rainer dot jung at kippdata dot de
Description:
------------
phpdbg correctly uses readling header files during compilation but does not link against libreadline during linking, so linkage fails because symbols readline and add_history are not know. Add -lreadline to the linking flags if libreadline existence was detected.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-01-25 15:20 UTC] rainer dot jung at kippdata dot de
Workaround: Add "-lreadline" to PHPDBG_EXTRA_LIBS.

The file needing libreadline is sapi/phpdbg/phpdbg_cmd.c.
 [2014-01-27 07:40 UTC] krakjoe@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: krakjoe
 [2014-01-27 07:40 UTC] krakjoe@php.net
The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.

This is fixed in the master repository for phpdbg, which will be merged into the php-src tree before the next alpha release of 5.6
 [2014-01-27 08:02 UTC] rainer dot jung at kippdata dot de
In addition: the readline lib has a dependency on the termcap or curses or ncurses lib. It is *not* linked against those to let applications using libreadline decide which one they want to use. So when linking against the readline lib, one also has to add one of termcap, curses or ncurses. See the detection mechanism for the php readline extension.
 [2014-04-22 04:19 UTC] glen at delfi dot ee
this is NOT FIXED as of php5.6.0alpha1

the fix is committed here:
https://github.com/krakjoe/phpdbg/commit/1c0fccfc9abaaea02ae717547bc3b69fcb2de86c

but NOT in php-src !!!
 [2014-04-22 04:24 UTC] glen at delfi dot ee
rainer: can you reopen this bug (you know bug password), and change state Assigned->Open then the bug should be spotted better.

i don't know why krakjoe@php.net said commit is made, if Git/SVN commits tab is empty and as you can see fix is not present in next version

similar annoyance is in https://bugs.php.net/bug.php?id=63228 - they claim patches applied but really not (5 time reported there that patch not applied and each time someone claims it's applied!) i suppose it's common issue with php-src that they have no control and lose patches :S, they do not even respond why it was not applied, no shame
 [2014-04-22 07:09 UTC] krakjoe@php.net
> i don't know why krakjoe@php.net said commit is made,

Yes you do, you just linked to the commit in the very last message you wrote.

The commit was pushed into php-src last night from the repository you linked too, I'm pretty sure you know how this works.

I don't know what makes you feel entitled to communicate with us like this, but, if you're going to be a dick, you are not entitled to a response, ever.
 [2014-05-06 23:31 UTC] tyrael@php.net
for the record.
glen was right that the fix isn't made into php-src for 5.6.0alpha1, but he was wrong about the fix not being in php-src.git the time when he made that comment, as it was merged a day before:
http://git.php.net/?p=php-src.git;a=commitdiff;h=708af5fd8e3b279aa2f6343e369e26a67d8bedc1

the original fix also needed a a little bit more work, as we also support libedit for interactive mode:

http://git.php.net/?p=php-src.git;a=commitdiff;h=c8d8e851fa7b8993c935d0f978bfa7eac62f484d;hp=bcf85252e24e078bb0690fd0a99226449fe51c26

glen, don't trust the Git/SVN commits tab too much, it only lists the commits which contains references to bug numbers in a very specific format, and even when the comment is matching, there are other factors, which can prevent the bug notification to reach from the git receive hook to the bugsweb database.

thanks for the reports, and sorry for the issues with your reports, but we are all humans, and make mistakes.
and when you are using this passive aggressive style, and make snarky comments like your last one that doesn't really help either.
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Sat Oct 31 17:01:24 2020 UTC