php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #66272 Some constants are not defined
Submitted: 2013-12-12 11:57 UTC Modified: 2013-12-13 10:30 UTC
Votes:2
Avg. Score:5.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: sergey dot zavg at gmail dot com Assigned: tony2001 (profile)
Status: Closed Package: sphinx (PECL)
PHP Version: 5.5Git-2013-12-12 (snap) OS: Linux CentOS-64-64-minimal 2.6.3
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: sergey dot zavg at gmail dot com
New email:
PHP Version: OS:

 

 [2013-12-12 11:57 UTC] sergey dot zavg at gmail dot com 
Description:
------------
This piece of code in sphinx.c is not working, cause #ifdef does not check enum values definitions.

#ifdef SPH_RANK_PROXIMITY
        SPHINX_CONST(SPH_RANK_PROXIMITY);
#endif
#ifdef SPH_RANK_MATCHANY
        SPHINX_CONST(SPH_RANK_MATCHANY);
#endif
#ifdef SPH_RANK_FIELDMASK
        SPHINX_CONST(SPH_RANK_FIELDMASK);
#endif
#ifdef SPH_RANK_SPH04
        SPHINX_CONST(SPH_RANK_SPH04);
#endif
#ifdef SPH_RANK_EXPR
        SPHINX_CONST(SPH_RANK_EXPR);
#endif
#ifdef SPH_RANK_TOTAL
        SPHINX_CONST(SPH_RANK_TOTAL);
#endif

So the constants SPH_RANK_PROXIMITY, SPH_RANK_MATCHANY,  SPH_RANK_FIELDMASK, SPH_RANK_SPH04, SPH_RANK_EXPR, SPH_RANK_TOTAL are anavailable from PHP even if they are defined in enum in sphinxclient.h.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-12-12 12:11 UTC] tony2001@php.net
-Status: Open +Status: Feedback
 [2013-12-12 12:11 UTC] tony2001@php.net 
Could you please clarify what exactly you mean by "#ifdef does not check enum values definitions" ?
These are constants. If there are defined, then ifdef result is true. If they aren't defined - it's false.
 [2013-12-12 14:41 UTC] sergey dot zavg at gmail dot com
-Status: Feedback +Status: Open
 [2013-12-12 14:41 UTC] sergey dot zavg at gmail dot com 
Here is the part of content of my sphinxclinet.h file.

/// known ranking modes (ext2 only)
enum
{
        SPH_RANK_PROXIMITY_BM25 = 0,
        SPH_RANK_BM25                   = 1,
        SPH_RANK_NONE                   = 2,
        SPH_RANK_WORDCOUNT              = 3,
        SPH_RANK_PROXIMITY              = 4,
        SPH_RANK_MATCHANY               = 5,
        SPH_RANK_FIELDMASK              = 6,
        SPH_RANK_SPH04                  = 7,
        SPH_RANK_EXPR                   = 8,
        SPH_RANK_TOTAL                  = 9,


        SPH_RANK_DEFAULT                = SPH_RANK_PROXIMITY_BM25
};

You can see that SPH_RANK_EXPR is here but #ifdef SPH_RANK_EXPR will not got it.                   

So I have to use $s->setRankingMode($8, "sum(1)"); in my PHP code.
 [2013-12-12 14:43 UTC] sergey dot zavg at gmail dot com 
Sorry, noticed 2 typos in the previous comment
 - sphinxclient.h 
 - $s->setRankingMode(8, "sum(1)");
 [2013-12-12 15:08 UTC] tony2001@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: tony2001
 [2013-12-12 15:08 UTC] tony2001@php.net 
Ah, you're absolutely right, these constants are undefined for the preprocessor.
I'll have to think how to detect them in compile time properly..
 [2013-12-13 10:30 UTC] tony2001@php.net
-Status: Assigned +Status: Closed
 [2013-12-13 10:30 UTC] tony2001@php.net 
Ok, unfortunately it looks like there's no other way than to check for these constants in ./configure.
I've committed a patch for it and will probably release a new version sometime soon.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 19 19:01:28 2024 UTC