php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #65547 Default value for sunrise/sunset zenith still wrong
Submitted: 2013-08-25 09:31 UTC Modified: 2018-02-08 17:16 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: df1986 at aol dot com Assigned:
Status: Verified Package: Date/time related
PHP Version: 5.4.19 OS: All
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: df1986 at aol dot com
New email:
PHP Version: OS:

 

 [2013-08-25 09:31 UTC] df1986 at aol dot com
Description:
------------
I have discovered https://bugs.php.net/bug.php?id=49448 this bug report filed 
several years ago which, quite correctly, points out that php's default zenith 
is 90 + 35/60.

However, the official algorithm from the 1990 Almanac for Computers published by 
the Nautical Almanac Office at the United States Naval Observatory (which can be 
found at http://williams.best.vwh.net/sunrise_sunset_algorithm.htm) quite 
clearly says that the correct value is 90+50/60.

The old bug was closed as bogus with a message saying that "the algorithm code 
we use clearly says 35/60". That statement is nothing more than a tautology. It 
says "the code should be 35/60 because if you look at the code, it says 35/60", 
and does nothing to answer where this value came from, or why it differs from 
the canonical value. Some commenters had noted this, but there was no response.

As such, I'd like to reopen this bug and see it correctly fixed, rather than 
simply swept under the carpet.

Test script:
---------------
echo ini_get("date.sunset_zenith"), "\n", ini_get("date.sunrise_zenith"), "\n", (90 + 50/60), "\n";

Expected result:
----------------
90.833333333333
90.833333333333
90.833333333333

Actual result:
--------------
90.583333
90.583333
90.833333333333

Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-02-08 17:16 UTC] cmb@php.net
-Status: Open +Status: Verified
 [2018-02-08 17:16 UTC] cmb@php.net
Yes, you're right.
<http://aa.usno.navy.mil/faq/docs/RST_defs.php> explains why it
should be 90° 50'.
 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Thu Dec 13 20:01:26 2018 UTC