php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #64885 getlastmod() should (optionally) check modification times of include files also
Submitted: 2013-05-21 01:57 UTC Modified: 2020-01-06 00:56 UTC
Votes:2
Avg. Score:5.0 ± 0.0
Reproduced:2 of 2 (100.0%)
Same Version:1 (50.0%)
Same OS:1 (50.0%)
From: dean at omnivisiontechnology dot com Assigned:
Status: Suspended Package: Filesystem function related
PHP Version: 5.5.0RC1 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: dean at omnivisiontechnology dot com
New email:
PHP Version: OS:

 

 [2013-05-21 01:57 UTC] dean at omnivisiontechnology dot com
Description:
------------
Currently the getlastmod() function is essentially an alias for filemtime($_SERVER["SCRIPT_FILENAME"]).

Considering that a primary use case for this function is to supply the time for a HTTP Last-Modified header, and that the output of the page may change if any of its include or require files change, it would be nice to have the option for getlastmod() to return the latest modification time of (any of) the main script AND its includes (recursively, checking includes of includes and so on).  (At least the ones included up to the time the function was called, if they can't be checked in advance during some parsing phase?)

To preserve backward compatibility, this feature might be activated by passing the parameter "true", i.e. getlastmod(true) to check include files also.

A php-coded version of what I mean is included below just for clarification, although it can't (I think) check multiply-nested include files.




Test script:
---------------

function new_getlastmod($checkAll = false)
{
  if (!$checkAll) return getlastmod();
  $t = 0;
  foreach(get_included_files() as $f)
    if ((($mt = filemtime($f))!==false)&&($mt>$t)) $t = $mt;
  return ($t ? $t : false);
}


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-01-05 13:12 UTC] cmb@php.net
-Status: Open +Status: Suspended
 [2020-01-05 13:12 UTC] cmb@php.net
The given test script shows that this functionality can easily be
implemented in userland, so adding it as built-in feature appears
to be doubtful.  If you still like to see it, please pursue the
RFC process[1].

[1] <https://wiki.php.net/rfc/howto>
 [2020-01-06 00:56 UTC] dean at omnivisiontechnology dot com
Sure it can be done in user code.

But my point was that if you're going to have a built-in getlastmod() function at all, it should probably fulfill the primary use-case users would want to use it for.  I'd note that the *existing* getlastmod() can also be recreated using user code, so if the argument is "we won't implement core functions if they can be recreated in user code", there's no reason for getlastmod() to exist at all!

I posted this nearly 7 years ago, I don't have the time to pursue an RFC for it now, sorry.
 [2020-01-06 01:23 UTC] bugreports at gmail dot com
> this functionality can easily be implemented in userland

getlastmod() too by just write filemtime(__FILE__) and to make it more useful it should do a little more than filemtime(__FILE__) or you can deprectate and remove it altogehter
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Thu Sep 23 01:03:33 2021 UTC