php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #63144 Frontport 2.2.7 macro improvements to 3.0 branch
Submitted: 2012-09-23 18:33 UTC Modified: 2013-10-11 05:41 UTC
From: silvas91 at sapo dot pt Assigned: pajoye (profile)
Status: Closed Package: memcache (PECL)
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: silvas91 at sapo dot pt
New email:
PHP Version: OS:

 

 [2012-09-23 18:33 UTC] silvas91 at sapo dot pt
Description:
------------
I've noticed that some macros have been changed/added in 2.2.7 to fix PHP 5.4 compatibility but those changes were not frontported to 3.0.7, instead version checks are made in every occurrence of similar code.

zend_list_insert(mmc, le_memcache_server);

In version 2.2.7, code like this has been changed to:
MEMCACHE_LIST_INSERT(mmc, le_memcache_server);

While, in version 3.0.7, code like this has been changed to:
#if (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 3)
			zend_list_insert(mmc, le_memcache_server);
#else
			zend_list_insert(mmc, le_memcache_server TSRMLS_CC);
#endif

In my understanding code should be kept consistent with all php versions and extension branches to make fixing issues easier.

Also, there was a macro being renamed in 2.2.7, IS_CALLABLE to MEMCACHE_IS_CALLABLE, this change makes code further readable and should be frontported to version 3.0.7 or later.


Patches

memcache-3.0.8.bug63144.diff (last revision 2013-04-08 11:16 UTC by neweracracker at gmail dot com)
memcache-3.0.7.fixed.diff (last revision 2012-09-23 18:34 UTC by silvas91 at sapo dot pt)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-10-11 05:40 UTC] pajoye@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=pecl/caching/memcache.git;a=commit;h=c29bb33ed6a78f6094fe3c1037a965c0b7c2a5d5
Log: fix #63144, sync macro for zend_list_instert
 [2013-10-11 05:40 UTC] pajoye@php.net
-Status: Open +Status: Closed
 [2013-10-11 05:41 UTC] pajoye@php.net
-Assigned To: +Assigned To: pajoye
 [2013-10-11 05:41 UTC] pajoye@php.net
fixed in branch "nio" (3.x branch)
 [2013-10-11 06:12 UTC] pajoye@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=pecl/caching/memcache.git;a=commit;h=e7acb33130780679b4942141fe3f5895551e1e2a
Log: fix #63144, sync macro for zend_list_instert
 [2013-10-15 11:39 UTC] tyrael@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=pecl/caching/memcache.git;a=commit;h=e7acb33130780679b4942141fe3f5895551e1e2a
Log: fix #63144, sync macro for zend_list_instert
 [2013-10-15 11:39 UTC] tyrael@php.net
Automatic comment on behalf of pajoye
Revision: http://git.php.net/?p=pecl/caching/memcache.git;a=commit;h=c29bb33ed6a78f6094fe3c1037a965c0b7c2a5d5
Log: fix #63144, sync macro for zend_list_instert
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue May 14 03:01:30 2024 UTC