php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #62736 Patches should link to PHP manual
Submitted: 2012-08-03 05:15 UTC Modified: 2012-10-26 21:38 UTC
From: philip@php.net Assigned: yannick (profile)
Status: Closed Package: Online Doc Editor problem
PHP Version: Irrelevant OS: irrelevant
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: philip@php.net
New email:
PHP Version: OS:

 

 [2012-08-03 05:15 UTC] philip@php.net 
Description:
------------
It would be useful to view the manual page when looking at a patch/diff so we can 
better understand the context of said patch. So, the edit string would link to 
the PHP Manual page where the change will exist (if committed).

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-10-01 19:57 UTC] yannick@php.net 
When you open a diff, actually, we just output the content of the diff.

We can cut the page in 2 columns ; first will display the content of the patch (as actually) and the second can, either :

1) display the PHP Manual page changed by this patch. This solution is a problem for non English page. Actually, we can only compile an EN page on the fly, not a translated page

2) display the xml modified by the patch

3) display the original xml page
 [2012-10-22 16:28 UTC] philip@php.net 
To clarify, I was meaning we link to the current manual page, and not actually 
build it or worry about that. 

For example, if a patch affects the strlen() docs, then simply add a link to 
http://docs.php.net/strlen to optionally see how the commit will affect the 
current documentation.
 [2012-10-26 21:33 UTC] yannick@php.net
-Status: Open +Status: Closed
 [2012-10-26 21:33 UTC] yannick@php.net 
Automatic comment on behalf of yannick.torres@gmail.com
Revision: http://git.php.net/?p=web/doc-editor.git;a=commit;h=ede07a3bcdaf79bad0398ff7dce7516232df8d12
Log: Fix bug #62736 : When we display the content of a diff, we try to display the original documentation page to view better the proposed change
 [2012-10-26 21:38 UTC] yannick@php.net 
This bug has been fixed in SVN, and should show up online in an
hour or three.

Thank you for the report, and for helping us make PHP.net better.
 [2012-10-26 21:38 UTC] yannick@php.net
-Assigned To: +Assigned To: yannick
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun May 05 22:01:29 2024 UTC