php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #62735 Work in progress commits
Submitted: 2012-08-03 05:04 UTC Modified: 2012-10-25 16:20 UTC
From: philip@php.net Assigned: yannick (profile)
Status: Closed Package: Online Doc Editor problem
PHP Version: Irrelevant OS: irrelevant
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: philip@php.net
New email:
PHP Version: OS:

 

 [2012-08-03 05:04 UTC] philip@php.net 
Description:
------------
It should be easier to commit 'Work in Progress' patches because realistically 
most people leave patches here, and never move them to 'Patches for Review'

This bug is related to #60300

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-10-22 20:03 UTC] yannick@php.net
-Assigned To: +Assigned To: yannick
 [2012-10-22 20:03 UTC] yannick@php.net 
I just commit a solution :

http://git.php.net/?p=web/doc-
editor.git;a=commit;h=c39244fa9c31a8bac9b08b2f5679cbeb8a4932c7

Now, when you're right click on an anonymous change, directly into 'Work in 
progress' module, the 'admin menu' allow you to push this change directly into 
your patch's list. This allow to commit the change more "quickly".

Is you're Ok with this solution ?
 [2012-10-23 17:17 UTC] philip@php.net 
I think any @php.net user should be able to commit them (or rather, handle them 
like 'Patches for Review' changes) as opposed to only allowing an admin to commit 
the change.
 [2012-10-25 16:18 UTC] yannick@php.net
-Status: Assigned +Status: Closed
 [2012-10-25 16:18 UTC] yannick@php.net 
Automatic comment on behalf of yannick.torres@gmail.com
Revision: http://git.php.net/?p=web/doc-editor.git;a=commit;h=80e162ecbd61ea954cd9c4c891a1a324eb7cca18
Log: Fix bug #62735 : A VCS user can know put a modified file in one of these patch, regardless of who made the change (VCS user, anonymous, etc...
 [2012-10-25 16:20 UTC] yannick@php.net 
This bug has been fixed in SVN, and should show up online in an
hour or three.

Thank you for the report, and for helping us make PHP.net better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Mon May 06 05:01:31 2024 UTC