php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #61822 asXML($filename) url-decodes $filename
Submitted: 2012-04-23 02:16 UTC Modified: 2020-03-21 18:37 UTC
Votes:7
Avg. Score:4.0 ± 0.5
Reproduced:7 of 7 (100.0%)
Same Version:0 (0.0%)
Same OS:3 (42.9%)
From: Aldo at WebVyz dot com Assigned:
Status: Verified Package: *XML functions
PHP Version: * OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: Aldo at WebVyz dot com
New email:
PHP Version: OS:

 

 [2012-04-23 02:16 UTC] Aldo at WebVyz dot com
Description:
------------
I was saving a SimpleXML object and kept getting errors that the file could not be written. Upon further examination, I discovered that the directory containg an url-encoded slash (%2F) and while the directory existed as an encoded string (e.g. 'dir1%2Fdir2/file.xml') asXML was explicitly unencoding it and attempting to write to a different directory (which does not exist, e.g. 'dir1/dir2.xml'). No amounts of double-encoding the filename succeeded in creating the file successfully (same error) so I had to resort to file_put_contents("{$dirname}/file.xml", $sXML->saveXML());

Test script:
---------------
$sXML = new SimpleXMLElement('<result />');
$filename = 'dir1%2Fdir2/result.xml';
mkdir(dirname($filename));
file_put_contents($filename, $sXML->asXML()); // works as expected
$sXML->asXML($filename); // fails; no such file/directory

Expected result:
----------------
Filename arguments given to asXML should be accepted without url-decoding

Actual result:
--------------
filenames are being url-decoded, which is not what I want or expect

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-07-15 11:53 UTC] yohgaki@php.net
-Status: Open +Status: Verified -PHP Version: 5.3.10 +PHP Version: *
 [2020-03-21 18:37 UTC] cmb@php.net
-Package: SimpleXML related +Package: *XML functions
 [2020-03-21 18:37 UTC] cmb@php.net
This is a general issue with our libxml2 bindings; for instance,
DOMDocument::saveHTMLFile() shows the same behavior:

<?php
$filename = 'dir1%2Fdir2/result.xml';
mkdir(dirname($filename));
$doc = new DOMDocument();
$doc->saveHTMLFile($filename);
?>

Warning: DOMDocument::saveHTMLFile(dir1/dir2/result.xml): failed to open stream: No such file or directory
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Mar 19 06:01:30 2024 UTC