php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #60440 close bugs through commit comments
Submitted: 2011-12-04 15:49 UTC Modified: 2012-09-08 18:52 UTC
From: tyrael@php.net Assigned: felipe (profile)
Status: Closed Package: Website problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: tyrael@php.net
New email:
PHP Version: OS:

 

 [2011-12-04 15:49 UTC] tyrael@php.net 
Description:
------------
It would be nice if we could close bugs through the svn commit message.
A little bit of work on web/php-bugs/trunk/www/rpc.php and SVNROOT/commit-bugs.php 
would make this easy to implement.
I would suggest matching for "fixes #%d", but maybe somebody has a better 
alternative.

(maybe we should wait the DVCS integration with this...)

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-09-06 10:13 UTC] reeze dot xia at gmail dot com 
Seems we already implemented this right?
 [2012-09-06 18:13 UTC] philip@php.net 
It can add commit messages but it does not alter the bug status (e.g., Open-
>Closed) for a bug.

I keep debating this feature request with myself and remain undecided.
 [2012-09-07 03:14 UTC] reeze dot xia at gmail dot com 
Ah I thought that was implemented already, everytime a bug was fixed 
the bug was closed. I thought that was automated :)

I really like the idea, Almost every bug tracker have the feature,
then when we fix the bug and it will be closed magically.

if you decide to to that, there is a fact you might  want to know, 
the some commit may reported many times, eg:
https://bugs.php.net/bug.php?id=60194
if the bug was reopened we may need to handle this :)
 [2012-09-07 05:08 UTC] philip@php.net 
I blame git for all problems like that. :)
 [2012-09-08 18:52 UTC] felipe@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: felipe
 [2012-09-08 18:52 UTC] felipe@php.net 
This bug has been fixed in SVN. Since the websites are not directly
updated from the SVN server, the fix might need some time to spread
across the globe to all mirror sites, including PHP.net itself.

Thank you for the report, and for helping us make PHP.net better.

I have just implemented such feature for the git repository.
 [2012-09-08 18:56 UTC] reeze dot xia at gmail dot com 
\o/
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri May 17 18:01:33 2024 UTC