php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #60298 PHP 5.4.0RC1 - Tests failed : 2
Submitted: 2011-11-14 17:45 UTC Modified: 2011-12-26 22:50 UTC
From: fedora at famillecollet dot com Assigned: pajoye
Status: Closed Package: igbinary (PECL)
PHP Version: 5.4.0RC1 OS: GNU/Linux (Fedora 15)
Private report: No CVE-ID:
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: fedora at famillecollet dot com
New email:
PHP Version: OS:

 

 [2011-11-14 17:45 UTC] fedora at famillecollet dot com
Description:
------------
Tried with 1.1.1 and latest git snapshot.



Test script:
---------------
make test


Expected result:
----------------
Test failed : 0

Actual result:
--------------
=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   30
---------------------------------------------------------------------

Number of tests :   44                41
Tests skipped   :    3 (  6.8%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    2 (  4.5%) (  4.9%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   39 ( 88.6%) ( 95.1%)
---------------------------------------------------------------------
Time taken      :    1 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Recursive objects [tests/igbinary_024.phpt]
Unserialize backwards compatible with v1. [tests/igbinary_unserialize_v1_compatible.phpt]
=====================================================================


$ cat tests/igbinary_024.diff
001+ 
001- objectrec
002- 17044f626a32140711026161001105002a006262001108004f626a32006363001109004f626a32006f626a17034f626a140311016106011104002a006206021106004f626a006306030e06060111016206021101630603
003- OK
004- objectrecarr
005- 17044f626a331401110a004f626a33006f626a731404060017034f626a140311016106001104002a006206001106004f626a0063060406011a0214030e0306000e0406010e05060406021a0214030e0306000e0406020e05060406031a0214030e0306000e0406030e050604
006- OK
007- objectselfrec
008- 17044f626a3414021107004f626a34006106641109004f626a34006f626a2200
009- OK

$ cat tests/igbinary_unserialize_v1_compatible.diff
001+ Differing unserialized: object
002+ Expected:
001- reference deserialization works, but the result is not a reference.
002- OK
003+ object(stdClass)#0 (4) {
004+   ["0"]=>
005+   int(1)
006+   ["1"]=>
007+   int(2)
008+   ["2"]=>
009+   int(3)
010+   ["3"]=>
011+   int(4)
012+ }
013+ 
014+ Actual:
015+ object(stdClass)#0 (4) {
016+   [0]=>
017+   int(1)
018+   [1]=>
019+   int(2)
020+   [2]=>
021+   int(3)
022+   [3]=>
023+   int(4)
024+ }
025+ 
026+ reference deserialization works, but the result is not a reference.
027+ OK


Patches

igbinary_024.patch (last revision 2011-11-14 17:49 UTC) by fedora at famillecollet dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-11-14 18:35 UTC] fedora at famillecollet dot com
About igbinary_unserialize_v1_compatible, it seems related to https://bugs.php.net/bug.php?id=55798.

I think igbinary unserialization result should be the same than PHP standard serializer.

Linked bug is fix in 5.3 branch, so the test will also failed when this version will be published.
 [2011-12-25 17:28 UTC] pajoye@php.net
hi!

Could you do a PR in github please? https://github.com/igbinary/igbinary/
 [2011-12-26 17:02 UTC] fedora at famillecollet dot com
See https://github.com/igbinary/igbinary/pull/11

This fixes only igbinary_024

Please also check igbinary_unserialize_v1_compatible and https://bugs.php.net/bug.php?id=55798
 [2011-12-26 22:50 UTC] pajoye@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 [2011-12-26 22:50 UTC] pajoye@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: pajoye
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Tue Aug 29 15:01:52 2017 UTC