php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #58489 -Werror=format-security
Submitted: 2009-01-04 07:49 UTC Modified: 2011-10-05 21:31 UTC
From: oden dot eriksson at envitory dot se Assigned:
Status: Closed Package: svn (PECL)
PHP Version: 5.2.5 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: oden dot eriksson at envitory dot se
New email:
PHP Version: OS:

 

 [2009-01-04 07:49 UTC] oden dot eriksson at envitory dot se
Description:
------------
The build fails with -Werror=format-security


Reproduce code:
---------------
/home/oden/RPM/BUILD/svn-0.5.0/svn.c: In function 'php_svn_handle_error':
/home/oden/RPM/BUILD/svn-0.5.0/svn.c:273: error: format not a string literal and no format arguments


Expected result:
----------------
It should build.

Actual result:
--------------
Proposed fix:

--- svn.c       2008-10-09 19:15:37.000000000 +0200
+++ svn.c.oden  2009-01-04 13:46:33.000000000 +0100
@@ -270,7 +270,7 @@ static void php_svn_handle_error(svn_err

        smart_str_appendl(&s, "\n", 1);
        smart_str_0(&s);
-       php_error_docref(NULL TSRMLS_CC, E_WARNING, s.c);
+       php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s", s.c);
        smart_str_free(&s);
 }



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-10-05 21:31 UTC] alan at akbkhome dot com
This bug has been fixed in SVN.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pecl.php.net.

In case this was a pecl.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PECL better.


 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Wed Dec 08 06:03:33 2021 UTC