|  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #57685 Accept string targets parameter in svn_commit()
Submitted: 2007-05-25 21:39 UTC Modified: 2008-02-26 10:51 UTC
From: edwardzyang at thewritingpot dot com Assigned:
Status: Closed Package: svn (PECL)
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
Solve the problem:
4 + 49 = ?
Subscribe to this entry?

 [2007-05-25 21:39 UTC] edwardzyang at thewritingpot dot com
This is a very humble feature request, a little bit of syntactic sugar to make developers happy. Currently, the svn_commit() function requires that the second parameter, $targets, be an array. Many times, developers only want to commit an entire directory, so quite often count($targets) will equal 1. If the targets array accepted a string as a single target, it would be greatly helpful.

Reproduce code:
svn_commit($log, 'file.txt');

Expected result:
Same results as if this were called:

svn_commit($log, array('file.txt'));

Actual result:
Error stating that $targets parameter must be an array.


Add a Patch

Pull Requests

Add a Pull Request


AllCommentsChangesGit/SVN commitsRelated reports
 [2008-02-26 10:51 UTC]
I just committed this to cvs, will be in 0.4.
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Wed Aug 12 05:01:26 2020 UTC