php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #57645 Debugging / Logging
Submitted: 2007-05-03 09:51 UTC Modified: 2007-06-11 12:53 UTC
From: michael dot caplan at henryschein dot com Assigned: mfp (profile)
Status: Closed Package: SCA_SDO (PECL)
PHP Version: 5.2.1 OS: CentOS 4
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: michael dot caplan at henryschein dot com
New email:
PHP Version: OS:

 

 [2007-05-03 09:51 UTC] michael dot caplan at henryschein dot com
Description:
------------
Ideally, I'd like to turn off all file_put_contents() calls that dump debugging info (xmlrpc requests, wsdl generation) throughout the file system.  In production mode, i don't care for this info, and it is an unnecessary performance penalty.

Also, is there any way I can disable the logger so that it does not create a temp directory when the logger is disabled?


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2007-05-03 10:45 UTC] mfp@php.net
Ouch, the ones in the Server, ServiceRequestHandler and Proxy for XMLRPC are definitely just for debugging and should not have been left turned on. I have just commented those ones out and checked the changes back in. That leaves just two active uses of f_p_c:

1. in the serviceRequestHandler for jsonrpc
2. in the serviceRequestHandler for soap

we write these into the file system for two reasons - 1 to save regenerating them and 2 for the soap server we need some wsdl to pass to the php_soap extension, and as a file is the simplest way to do it. Actually our logic is suspect in these cases as we don't regenerate when the file changes. But anyway, for the moment we need to keep those two. 

And, WRT the logger we should not be creating a temp directory when we don't need to. That was also a bit poor. I will fix that next.
 [2007-05-03 11:29 UTC] mfp@php.net
I've just moved the logic that decides the location of the log by creating a temporary file into SCA_Logger::startlog(), so it doesn't happen if the logging is off. 

I am just in the process of making a new release, so these changes will get into that. I was going to look at your other defect first to see if I can slip that in quickly. 

Thanks for telling us about these problems. If you have other ideas and / or requests do let us know: if you want developer access and want to fix the code too, we can arrange that and you'd be welcome.
 [2007-06-11 12:53 UTC] mfp@php.net
This one was fixed a few weks ago, so closing.
 
PHP Copyright © 2001-2022 The PHP Group
All rights reserved.
Last updated: Tue Jan 25 02:03:35 2022 UTC