php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #57604 Incorrect proto declaration for svn_commit
Submitted: 2007-04-03 20:48 UTC Modified: 2007-04-03 23:31 UTC
From: edwardzyang at thewritingpot dot com Assigned:
Status: Closed Package: svn (PECL)
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
19 - 18 = ?
Subscribe to this entry?

 
 [2007-04-03 20:48 UTC] edwardzyang at thewritingpot dot com
Description:
------------
The proto declaration for svn_commit is incorrect, being exactly the same as the hotcopy function. Patch is below.

Reproduce code:
---------------
Index: svn.c
===================================================================
RCS file: /repository/pecl/svn/svn.c,v
retrieving revision 1.23
diff -u -r1.23 svn.c
--- svn.c	18 Apr 2006 03:11:52 -0000	1.23
+++ svn.c	4 Apr 2007 00:45:04 -0000
@@ -1646,7 +1646,7 @@
 }
 
 /* {{{ proto array svn_commit(string log, array targets [, bool dontrecurse])
-   Make a hot-copy of the repos at repospath; copy it to destpath */
+   Sends changes from the local working copy to the repository */
 PHP_FUNCTION(svn_commit)
 {
 	char *log;


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2007-04-03 20:59 UTC] edwardzyang at thewritingpot dot com
Updated patch: svn_status is also incorrectly documented

Index: svn.c
===================================================================
RCS file: /repository/pecl/svn/svn.c,v
retrieving revision 1.23
diff -u -r1.23 svn.c
--- svn.c	18 Apr 2006 03:11:52 -0000	1.23
+++ svn.c	4 Apr 2007 00:57:54 -0000
@@ -1646,7 +1646,7 @@
 }
 
 /* {{{ proto array svn_commit(string log, array targets [, bool dontrecurse])
-   Make a hot-copy of the repos at repospath; copy it to destpath */
+   Sends changes from the local working copy to the repository */
 PHP_FUNCTION(svn_commit)
 {
 	char *log;
@@ -1728,7 +1728,7 @@
 /* }}} */
 
 /* {{{ proto array svn_status(string path [, bool recursive [, bool get_all [, bool update [, bool no_ignore]]]])
-   Schedule the addition of a file in a working directory */
+   Returns the status of working copy files and directories */
 
 static void status_func(void *baton, const char *path, svn_wc_status_t *status)
 {
 [2007-04-03 23:31 UTC] alan at akbkhome dot com
This bug has been fixed in CVS.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pecl.php.net.

In case this was a pecl.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PECL better.

thanks
Regards
Alan
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Sat Nov 28 01:01:23 2020 UTC