php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #57131 do not mail in active developers
Submitted: 2006-07-10 14:45 UTC Modified: 2006-10-18 22:21 UTC
From: smith at pooteeweet dot org Assigned: davidc (profile)
Status: Closed Package: PECL website (PECL)
PHP Version: Irrelevant OS: irrelevant
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: smith at pooteeweet dot org
New email:
PHP Version: OS:

 

 [2006-07-10 14:45 UTC] smith at pooteeweet dot org
Description:
------------
it would be nice if developers that are marked as "in active" for a given package no longer receive email notifications for trackbacks and bugs (and anything else we mail maintainers for) for this package.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2006-10-18 16:58 UTC] davidc@php.net
http://dev.agoraproduction.com/pear/pearweb/bugs/8176/

I have put the fix in cvs diff -u there. This is against the latest cvs up -dP I had.

So explanation:
File:
include/Damblan/Trackback.php
----> This function has the function getMaintainers() and I have added a new param set by default to false which is called $activeOnly. What you pass to this, will be automatically changing the call to maintainer::get and pass a third parameter which will be true or false.

include/pear-database.php
maintainer::get()
----> this function will execute the query on the database, thus I have made it that if you pass the new third parameter true to it, then it will check only the active set to 1.

public_html/trackback/trackback.php
----> I added true to the $trackback->getMaintainers() function in order to only get maintainers that are set to true. This $trackback variable is Damblan_Trackback instance, thus changed Damblan_Trackback::getMaintainers(true) so that it calls pear-database::maintainer::get('id', true, true) making pear-database::maintainer::get() query only the active lead.

If this is not clear just look at the patches, should be rather simple and straightforward.
 [2006-10-18 22:21 UTC] cellog@php.net
This bug has been fixed in CVS.

If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.


 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Wed Dec 01 19:03:37 2021 UTC